Skip to content

url: add a got host pattern in url.js - #9653

Closed
AxelMonroyX wants to merge 1 commit into
nodejs:masterfrom
AxelMonroyX:add-gott-host-pattern
Closed

url: add a got host pattern in url.js#9653
AxelMonroyX wants to merge 1 commit into
nodejs:masterfrom
AxelMonroyX:add-gott-host-pattern

Conversation

@AxelMonroyX

@AxelMonroyXAxelMonroyX commented Nov 17, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add a hostPattern variable for readable purposes

@nodejs-github-botnodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Nov 17, 2016
@AxelMonroyXAxelMonroyX changed the title lib: add a got host pattern in url.jsurl: add a got host pattern in url.jsNov 17, 2016
@mscdex

mscdex commented Nov 17, 2016

Copy link
Copy Markdown
Contributor

Maybe hostPattern is a better, shorter name?

Also, it seems your branch has some conflicts.

@AxelMonroyX

AxelMonroyX commented Nov 17, 2016

Copy link
Copy Markdown
ContributorAuthor

@mscdex Ready

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add a hostPattern variable for readable purposes

@mscdex

mscdex commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

LGTM

@targos

targos commented Nov 19, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4910/

@jasnell

jasnell commented Dec 5, 2016

Copy link
Copy Markdown
Member

@AxelMonroyX ... can I ask you to please squash the commits. this is not landing cleanly on master with the merge commit there.

@AxelMonroyX
url: add a got host pattern in url.js
1b4348a
Add a hostPattern variable for readable purposes
@AxelMonroyX

AxelMonroyX commented Dec 6, 2016

Copy link
Copy Markdown
ContributorAuthor

@jasnell Ready

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add a hostPattern variable for readable purposes

jasnell pushed a commit that referenced this pull request Dec 6, 2016
@AxelMonroyX@jasnell
url: add a got host pattern in url.js
1be73e8
Add a hostPattern variable for readable purposes
PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell

jasnell commented Dec 6, 2016

Copy link
Copy Markdown
Member

Landed in 1be73e8. Thank you!

Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
@AxelMonroyX@Fishrock123
url: add a got host pattern in url.js
19d7197
Add a hostPattern variable for readable purposes
PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@evanlucas

evanlucas commented Dec 14, 2016

Copy link
Copy Markdown
Contributor

Closing since this has landed. Thanks!

@italoacasasitaloacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@AxelMonroyX@MylesBorins
url: add a got host pattern in url.js
0919991
Add a hostPattern variable for readable purposes
PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@AxelMonroyX@MylesBorins
url: add a got host pattern in url.js
3666879
Add a hostPattern variable for readable purposes
PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@AxelMonroyX@MylesBorins
url: add a got host pattern in url.js
3ac9e01
Add a hostPattern variable for readable purposes
PR-URL: #9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes

Assignees

No one assigned

Labels

urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@AxelMonroyX@mscdex@targos@jasnell@evanlucas@lpinca@MylesBorins@nodejs-github-bot