Uh oh!
There was an error while loading. Please reload this page.
tools: allow test.py to use full paths of tests - #9694
Closed
reconbot wants to merge 1 commit into
Closed
Conversation
princejwesley
approved these changes
Nov 19, 2016
Fishrock123
commented
Nov 19, 2016
Contributor
gibfahn
approved these changes
Nov 19, 2016
gibfahn
left a comment
Member
There was a problem hiding this comment.
Looking forward to no more No tests to run because you copied the .js as well. Also tab-complete for tests is great.
reconbot
commented
Nov 19, 2016
ContributorAuthor
@thealphanerd freebsd failed but I can't figure out what failed, I see "no failures"
|
Contributor
failure looks infra related /cc @nodejs/build fixes #9684 |
jbergstroem
commented
Nov 19, 2016
Member
@thealphanerd what you meant to say was "the failure looks @jbergstroem-related". Should be fixed now. |
MylesBorins
commented
Nov 19, 2016
Contributor
@jbergstroem you are a hero! Thank you for all the hard infra work you do. |
jbergstroem
commented
Nov 19, 2016
Member
@thealphanerd thanks! if only the work wasn't so tied to fixing my other work :) |
thefourtheye
suggested changes
Nov 20, 2016
Contributor
There was a problem hiding this comment.
Use startswith and endswith.
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix Fixes: nodejs#9684
reconbot
commented
Nov 20, 2016
ContributorAuthor
@thefourtheye updated to use |
thefourtheye
approved these changes
Nov 21, 2016
thefourtheye
left a comment
Contributor
There was a problem hiding this comment.
Nice. LGTM. Thanks :)
gibfahn
approved these changes
Nov 21, 2016
MylesBorins
commented
Nov 26, 2016
Contributor
landed in 951ba0d |
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2016
Allow test.py to run tests with a 'tests/' prefix or a '.js' postfix PR-URL: #9694Fixes: #9684 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Fixes: #9684
tools/test.pycan now take paths likeDescription of change
Slices off the
test/and the.json input files. Wildcards likeparallel/test-cluster-*will still work as will defaults.