Uh oh!
There was an error while loading. Please reload this page.
Tests: Refactored to es6 - #9700
Closed
itsmed wants to merge 6 commits into
Closed
Conversation
mscdex
commented
Nov 19, 2016
Contributor
cjihrig
requested changes
Nov 20, 2016
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
Can you update the commit message according to https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit.
Contributor
There was a problem hiding this comment.
Can you change { 'fd': fd } to just { fd }.
Contributor
There was a problem hiding this comment.
Can you replace the throws with common.fail().
itsmed
commented
Nov 20, 2016
ContributorAuthor
Ok, thanks. Changes made. |
cjihrig
approved these changes
Nov 23, 2016
jasnell
requested changes
Dec 5, 2016
Member
There was a problem hiding this comment.
The callback here should be wrapped in a common.mustCall()
Member
There was a problem hiding this comment.
The callback should be wrapped in a common.mustCall()
itsmed
commented
Dec 19, 2016
ContributorAuthor
Ok I think I've got it this time! |
italoacasas
approved these changes
Jan 16, 2017
jasnell
approved these changes
Jan 16, 2017
Changed var to const, assert.equal to assert.strictEqual
Replaced anonymous functions with arrow functions. Replaced throw new Error with common.fail.
Replaced anonymous functions with arrow functions. Replaced throw new Error with common.fail.
Changed var to const, assert.equal to assert.strictEqual
Replaced anonymous functions with arrow functions. Replaced throw new Error with common.fail.
itsmed
commented
Jan 18, 2017
ContributorAuthor
@italoacasas rebase done. |
joyeecheung
commented
Feb 6, 2017
Member
The previous CI job is gone. New CI: https://ci.nodejs.org/job/node-test-pull-request/6230/ |
fhinkel
approved these changes
Mar 26, 2017
fhinkel
commented
Mar 26, 2017
Member
fhinkel pushed a commit
that referenced
this pull request
Mar 26, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 28, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Apr 18, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Apr 19, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: #9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
andrew749 pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Replace anonymous functions with arrow functions. Replace throw new Error with common.fail. PR-URL: nodejs/node#9700 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Tests
Description of change
Changed var to const, assert.equal to assert.strictEqual. Changed anonymous functions to use arrow functions.