Skip to content

Use assert.strictEqual instead of assert.equal - #9952

Closed
nitsnwits wants to merge 1 commit into
nodejs:masterfrom
nitsnwits:master
Closed

Use assert.strictEqual instead of assert.equal#9952
nitsnwits wants to merge 1 commit into
nodejs:masterfrom
nitsnwits:master

Conversation

@nitsnwits

@nitsnwitsnitsnwits commented Dec 1, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Checklist

  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Affected core subsystem(s)

Test

Description of change

convert assert.equal to assert.strictEqual

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

@nitsnwits May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@nitsnwits
test: use strictEqual in test-cwd-enoent-repl.js
ec4f61d
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3
assert.equal was using. This commit includes changing
use of assert.equal to assert.strictEqual.
@nitsnwits

nitsnwits commented Dec 1, 2016

Copy link
Copy Markdown
ContributorAuthor

@imyller done!

@imyller

imyller commented Dec 1, 2016

Copy link
Copy Markdown
Member

@nitsnwits Excellent. Thank you 👍

@Trott

Trott commented Dec 20, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5484/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 21, 2016
@nitsnwits@Trott
test: use strictEqual in test-cwd-enoent-repl.js
fde5042
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: nodejs#9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Dec 21, 2016

Copy link
Copy Markdown
Member

Landed in fde5042
Thanks for the contribution! 🎉

@TrottTrott closed this Dec 21, 2016
@evanlucasevanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@nitsnwits@evanlucas
test: use strictEqual in test-cwd-enoent-repl.js
bc4d95e
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@nitsnwits@evanlucas
test: use strictEqual in test-cwd-enoent-repl.js
3448e8e
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@nitsnwits@MylesBorins
test: use strictEqual in test-cwd-enoent-repl.js
ec587bc
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@nitsnwits@MylesBorins
test: use strictEqual in test-cwd-enoent-repl.js
46d673a
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@nitsnwits@MylesBorins
test: use strictEqual in test-cwd-enoent-repl.js
167b394
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@nitsnwits@MylesBorins
test: use strictEqual in test-cwd-enoent-repl.js
09afc2d
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@nitsnwits@MylesBorins
test: use strictEqual in test-cwd-enoent-repl.js
61105d7
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@nitsnwits@MylesBorins
test: use strictEqual in test-cwd-enoent-repl.js
f301df4
In file /test/parallel/test-cwd-enoent-repl.js at
line: 26:3 and 27:3 assert.equal was used.
This commit changes use of assert.equal to assert.strictEqual.
PR-URL: #9952
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nitsnwits@imyller@Trott@jasnell@cjihrig@mscdex@MylesBorins@nodejs-github-bot