Skip to content

build: improve vcbuild.bat - #998

Closed
piscisaureus wants to merge 1 commit into
nodejs:v1.xfrom
piscisaureus:fix-vcbuild
Closed

build: improve vcbuild.bat#998
piscisaureus wants to merge 1 commit into
nodejs:v1.xfrom
piscisaureus:fix-vcbuild

Conversation

@piscisaureus

Copy link
Copy Markdown
Contributor
  • Support running multiple test suites (e.g. vcbuild test-simple test-gc).
  • Removed a nonexisting test suite (test-uv).
  • Removed superfluous extra layer of argument parsing.
  • Fix the node-weak build.

R=@rvagg

* Support running multiple test suites (e.g. vcbuild test-simple test-gc).
* Removed a nonexisting test suite (test-uv).
* Removed superfluous extra layer of argument parsing.
* Fix the node-weak build.
R=@rvagg
@piscisaureuspiscisaureus mentioned this pull request Feb 28, 2015
@rvagg

Copy link
Copy Markdown
Member

yep, works, lgtm

piscisaureus added a commit that referenced this pull request Feb 28, 2015
* Support running multiple test suites (e.g. vcbuild test-simple test-gc).
* Removed a nonexisting test suite (test-uv).
* Removed superfluous extra layer of argument parsing.
* Fix the node-weak build.
R=@rvagg
PR-URL: #998
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg

Copy link
Copy Markdown
Member

landed @ 25da074, I hope you don't mind me merging this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@piscisaureus@rvagg