Skip to content

test: updating test file to use strictEqual - #9985

Closed
ashtonian wants to merge 1 commit into
nodejs:masterfrom
ashtonian:node-update-es6-test-fix1
Closed

test: updating test file to use strictEqual#9985
ashtonian wants to merge 1 commit into
nodejs:masterfrom
ashtonian:node-update-es6-test-fix1

Conversation

@ashtonian

@ashtonianashtonian commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

updating test file to use assert.strictEqual() instead of
assert.equal()

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdexmscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@imyllerimyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex

mscdex commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

nit: there is a typo in the commit message

@ashtonianashtonian changed the title test: updatig test file to use strictEqualtest: updating test file to use strictEqualDec 1, 2016
@ashtonian
test: updating test file to use strictEqual
f053aac
updating test file to use assert.strictEqual() instead of
assert.equal()
@ashtonian

ashtonian commented Dec 1, 2016

Copy link
Copy Markdown
ContributorAuthor

Fixed.

cjihrig
cjihrig approved these changes Dec 3, 2016
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM.

@Trott

Trott commented Dec 8, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5304/

@Trott

Trott commented Dec 8, 2016

Copy link
Copy Markdown
Member

These changes have already landed via another pull request. Looks like I might have given this task out twice. Sorry for my error! Glad to see your other pull request (#10080) landed! I'm going to close this one. Again, sorry about my mistake!

@TrottTrott closed this Dec 8, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ashtonian@mscdex@Trott@jasnell@addaleax@cjihrig@imyller@nodejs-github-bot