chore(pr-template): add check list

[ovflowd]

Description

This PR updates the PR template to add a check-list

[codecov-commenter]

Codecov Report

Merging #2574 (630be77) into main (ab7c789) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2574 +/- ##
=======================================
Coverage 90.38% 90.38% =======================================
Files 87 87 Lines 998 998 Branches 270 270 =======================================
Hits 902 902 Misses 96 96 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab7c789...630be77. Read the comment docs.

[rodion-arr]

I'd like to recommend one additional item to the list: "I've covered new added functionality with unit tests"

[benhalverson]

👍

[benhalverson]

We should switch to the new github yaml templates.
https://github.com/nodejs/nodejs.org/pull/4751/files as an example.
Also consider not every PR is a code change.

[ovflowd]

Also consider not every PR is a code change.

Yeah, I believe this Check-List is more like a check what is applicable for you.

Regarding the YAML templates I think they're only for Issues now, no?

[benhalverson]

We have both issue templates and a PR template. https://github.com/nodejs/nodejs.dev/tree/main/.github
The docs show they support both. https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/manually-creating-a-single-issue-template-for-your-repository

This can be done in another PR if you prefer.

[ovflowd]

Cool! Let me rework this PR then!

[ovflowd]

We should switch to the new github yaml templates.
nodejs/nodejs.org#4751 (files) as an example.
Also consider not every PR is a code change.

I just checked the docs, and they don't seem to support Pull Requests for now:

https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms

[ovflowd]

I will update this PR to at least use the new Issue templates from nodejs/nodejs.org#4751 as they're super cool!

[ovflowd]

Re-requesting review from @rodion-arr@benhalverson

[benhalverson]

I was going to make the same suggestions as @mikeesto
👍🏻

[rodion-arr]

LGTM after suggestions fixes in the comment above