Skip to content

Migrate CommonComponents from nodejs.dev #5193

Description

@ovflowd

To kick off the migration of Components from the nodejs.dev repository, we should start migrating the CommonComponents from the nodejs.dev repository.

This issue will keep track of these components and their development progress. Remember that #5191 should be done first, as we want to migrate Components and add Storybooks for them.

The Migration of each Component

  • Each Component should go under components/Common folder on this repository
  • Each Component has its sub-folder (e.g., components/Common/Banner)
  • The folder structure should pretty much be the same (CSS components, React, and sub-components), but feel free to make changes if you see deemed
  • Please add some if the Component does not have unit tests already. At least to ensure the Component is rendering. If the Component has states/CTAs (Buttons/Triggers), please cover them too.
  • The Storybook of each component should allow interaction with all possible states of the Component
  • If the Component depends on Hooks, please migrate them too, with the following caveat:
    • If that component only uses the Hook, move it to the same folder of the Component
    • Otherwise, migrate it to the hooks folder of the repository.
  • If the Component has a Gatsby-specific logic (e.g. Dark Theme Switcher), if it is straightforward enough (e.g. a dark theme switcher plugin for Next.js or it is simple enough to code by ourselves, e.g. a Hook that we manage together with a React Provider) then feel free to do it.
    • Otherwise, if you have questions, please ask them on this Issue or your Draft PR for the Component.

List of Components to Migrate

Components not to migrate

  • Hero
    • The Hero Component will be directly part of the Home-page Layout and will be migrated afterwards once we start designing the Home Layout (It will reside under components/Home)
  • SearchBar
    • The Search Bar component is complex and requires first content-indexing, which probably requires SSR. Nevertheless, a dedicated issue will be opened for the component so that research and development might be completed.
  • SEO
    • The SEO component is obsolete and does not require a counterpart here as we already have a replacement.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    website redesignIssue/PR part of the Node.js Website Redesign

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions