Uh oh!
There was an error while loading. Please reload this page.
Update contributor-list/package-lock.json. - #1639
Conversation
This updates hoek@2 to hoek@4.2.1.
WaleedAshraf
commented
Apr 29, 2018
|
WaleedAshraf
left a comment
There was a problem hiding this comment.
I just ran the script without any error with these steps.
- Pulled latest
npm installGITHUB_API_TOKEN=<your token> node index.js <since date: YYYY-MM-DD>
Trott
commented
Apr 29, 2018
@WaleedAshraf It's in package-lock.json, not package.json, because it's a dependency of a dependency. |
Trott
commented
Apr 29, 2018
👍 Thanks! |
Trott
commented
Apr 29, 2018
(For what it's worth, those are the steps I took and it seemed to take a looooong time. Maybe I just wasn't patient enough? I think I waited a minute or two.) |
Maybe something with the date. What date you used? |
fhemberger
commented
Apr 29, 2018
@Trott Yes, it's still in use and it should work. ;) |
Trott
commented
Apr 30, 2018
I'm going to guess it's my API token/account permissions. Regardless, as long as it is working, great. |
fhemberger
commented
Apr 30, 2018
@Trott Why are there two PRs for this change? 🤔 |
WaleedAshraf
commented
Apr 30, 2018
@fhemberger One is for I think both can be closed? |
Trott
commented
Apr 30, 2018
No, they should not be closed. |
This updates hoek@2 to hoek@4.2.1.
I wasn't able to test the relevant script because it didn't work for me even with no changes. So, maybe someone else can confirm that it's still in use and that it works? (Maybe GitHub was having issues when I tried? I'm pretty sure my API token would have the needed permissions.)