Skip to content

add proper color for a:hover code - #170

Merged
fhemberger merged 1 commit into
nodejs:masterfrom
bogas04:issue168
Sep 18, 2015
Merged

add proper color for a:hover code#170
fhemberger merged 1 commit into
nodejs:masterfrom
bogas04:issue168

Conversation

@bogas04

Copy link
Copy Markdown
Contributor

Fix for #168

screen shot 2015-09-17 at 10 38 51 pm
becomes
screen shot 2015-09-17 at 10 40 31 pm

Comment threadlayouts/css/base.styl Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little nit picking, but separating the ordinary a:hover styling from the code element style improves readability IMO.

ATM this results in a stylus parser error as you forgot to add color before the hex below 😸

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad ! Achievement Unlocked, mess-up simple CSS fix

@bogas04

Copy link
Copy Markdown
ContributorAuthor

@phillipj I guess I can't mess it up anymore 🙈 let's merge it

fhemberger added a commit that referenced this pull request Sep 18, 2015
add proper color for a:hover code
@fhemberger
fhemberger merged commit c3adbbe into nodejs:masterSep 18, 2015
@fhemberger

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@bogas04@fhemberger@phillipj