Skip to content

fix: optimize zh-cn translate - #1793

Merged
2 commits merged into
nodejs:masterfrom
paranoidjk:fix-zhcn-locale
Sep 7, 2018
Merged

fix: optimize zh-cn translate#1793
2 commits merged into
nodejs:masterfrom
paranoidjk:fix-zhcn-locale

Conversation

@paranoidjk

Copy link
Copy Markdown
Contributor

No description provided.

@paranoidjk

Copy link
Copy Markdown
ContributorAuthor

cc/ @Maledong

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect and thanks anyway!
But I don't think it needs translating comments in the code snippet, because we want to keep it origin.

So what you can do now is to restore all your tranlated comments from Chinese back to English, and the submit to the same PR. I'll try to merge or tell you if there's anything wrong.

Many thanks again for you GREAT help!

let n = req.query.n;

// n iterations before giving someone else a turn
// 先执行 n 次循环,才给其他请求执行机会

@ghostghostSep 6, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs translating comments in the original codes because we want to keep it in origin. So please restore the rest part into the original English instead of Chinese here, if you take a close look at others' translations :)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine!
Wait for another one to approve and I'll do a merge.

@ghost

ghost commented Sep 7, 2018

Copy link
Copy Markdown

/cc: @nodejs/nodejs-cn, Have you any other suggestions? If no please agree again and I'll merge this.

@Lellansin

Copy link
Copy Markdown

LGTM

@terry-feiterry-fei left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost
ghost merged commit ddd2298 into nodejs:masterSep 7, 2018
@ghost

ghost commented Sep 7, 2018

Copy link
Copy Markdown

@paranoidjk:Thanks for your contributions!

This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@paranoidjk@Lellansin@terry-fei