Skip to content

translate includes - #1818

Merged
4 commits merged into
nodejs:masterfrom
zys-contrib:includes
Sep 29, 2018
Merged

translate includes#1818
4 commits merged into
nodejs:masterfrom
zys-contrib:includes

Conversation

@ZYSzys

Copy link
Copy Markdown
Member

translate includes

It looks like this now
en:
screen shot 2018-09-23 at 1 41 50 pm
ja:
screen shot 2018-09-23 at 1 42 23 pm
ko:
screen shot 2018-09-23 at 1 42 37 pm
zh-cn:
screen shot 2018-09-23 at 1 42 47 pm
zh-tw:
screen shot 2018-09-23 at 1 42 55 pm

@ghost

Copy link
Copy Markdown

The simplified and traditional Chinese are good. But Please don't forget to change the 'current' page:

image

/cc:@nodejs/nodejs-ja, @nodejs/nodejs-ko,please check whether the two languages are good or not :)

@ZYSzys

Copy link
Copy Markdown
MemberAuthor

Fixed. Thanks for your review.

Comment threadlocale/ja/download/current.md Outdated
Comment threadlocale/ja/download/index.md Outdated
intro: >
Node.js のソースコードをダウンロードするか、事前にビルドされたインストーラーを利用して、今日から開発を始めましょう。
currentVersion: 最新のバージョン
includes: 含有

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@ZYSzysZYSzysSep 27, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed, thanks.

@okuryuokuryu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost

Copy link
Copy Markdown

@nodejs/nodejs-ko:Sorry to disturb, but is this "내용" meaning "Include"?
If yes, please submit an Agreement and I'll merge them anyway :)

@yous

yous commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

"내용" usually means "Contents" in Korean.
Corresponding word of "Include" is "포함", but "(포함 npm 6.4.1)" doesn't sound natural to me. I prefer to put npm first, like "(npm 6.4.1 포함)".
If the word should come first, I'm not sure what's the appropriate one.

/cc @nodejs/nodejs-ko

@yous

yous commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

@outsideris@taggon How do you think?

@ghost

ghost commented Sep 28, 2018

Copy link
Copy Markdown

@ZYSzys:Maybe you can change this if free, according to what yous said.

@ZYSzys

Copy link
Copy Markdown
MemberAuthor

As 'includes' in ko is not certain, I choose to use 'includes' back.

Maybe they can modify it in the future.

@taggon

Copy link
Copy Markdown
Contributor

As @yous said, "내용" is not a correct translation for "includes". I'd like to keep "includes" if it is not able to put "포함" before the closing parenthesis.

@ghost
ghost merged commit 6a4d906 into nodejs:masterSep 29, 2018
@ghost

Copy link
Copy Markdown

Thanks all!

This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ZYSzys@yous@taggon@okuryu@watilde