Skip to content

fa: translate locale Persian "fa" (#1866) - #1874

Merged
fhemberger merged 8 commits into
nodejs:masterfrom
m-esm:master
Nov 1, 2018
Merged

fa: translate locale Persian "fa" (#1866)#1874
fhemberger merged 8 commits into
nodejs:masterfrom
m-esm:master

Conversation

@m-esm

@m-esmm-esm commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

site.json and some of website main pages translated to Persian "fa" language.

fhemberger
fhemberger reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/site.json
@@ -1,19 +1,19 @@
{

@fhembergerfhembergerNov 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pease check if the translations here for site.json against those in #1871?

@m-esmm-esmNov 1, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there are against #1871

reviews considered in the last commit and more parts translated.

@fhembergerfhembergerNov 1, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can merge this PR instead of #1871?

@m-esmm-esmNov 1, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. 😃

@fhemberger

fhemberger commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

/cc @nodejs/nodejs-fa Please review the translation. Depending on the complexity of changes, a review of one or two people is recommended. If everything is okay, click "Approve". Then we know it's ready to be merged into master.

ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
@ebraminio

ebraminio commented Nov 1, 2018

Copy link
Copy Markdown

LGTM with some nits

ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/about/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/index.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio reviewed Nov 1, 2018
View reviewed changes
Comment threadlocale/fa/security.md Outdated
ebraminio
ebraminio approved these changes Nov 1, 2018
View reviewed changes

@ebraminioebraminio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

Comment threadlocale/fa/security.md Outdated
Comment threadlocale/fa/security.md Outdated
Comment threadlocale/fa/security.md Outdated
@fhemberger

fhemberger commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

@m-esm@ebraminio Please let me know when you're done, everything is reviewed and you're good to merge.

ebraminio
ebraminio approved these changes Nov 1, 2018
View reviewed changes

@ebraminioebraminio left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhemberger
fhemberger merged commit dab02b1 into nodejs:masterNov 1, 2018
@fhemberger

fhemberger commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Thank you!

@snyk-botsnyk-bot mentioned this pull request Jan 20, 2021
Open
@dirgam92dirgam92 mentioned this pull request Mar 14, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Mar 21, 2023
Merged
@NOUIYNOUIY mentioned this pull request Apr 5, 2023
Open
@NOUIYNOUIY mentioned this pull request Apr 14, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@fhembergerfhembergerfhemberger left review comments
@armanatoryarmanatoryarmanatory left review comments
@ebraminioebraminioebraminio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@m-esm@fhemberger@ebraminio@armanatory