Skip to content

Fix typo in about/index.md AR - #2062

Closed
celyes wants to merge 2 commits into
nodejs:masterfrom
softvenue:master
Closed

Fix typo in about/index.md AR#2062
celyes wants to merge 2 commits into
nodejs:masterfrom
softvenue:master

Conversation

@celyes

Copy link
Copy Markdown
Contributor

Fixed the term "blocking call" to "non-blocking call" in about/index.md:41
@Aissaoui-Ahmed@interstellarClub

@ghost
ghost requested a review from fhembergerFebruary 11, 2019 00:17
Comment threadlocale/ar/about/index.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking is correct here, see https://nodejs.org/en/about/:

Typically behavior is defined through callbacks at the beginning of a script and at the end starts a server through a blocking call like EventMachine::run(). In Node there is no such start-the-event-loop call.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, Corrected the mistake.
@fhemberger

@ghost

Copy link
Copy Markdown

@celyes:You don't need to close it if you had a force push and fixed it, this could be also merged if possible :)

@celyes

Copy link
Copy Markdown
ContributorAuthor

@Maledong : thank you, but it's basically blank lines, so i don't think it deserves to be merged IMO.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@celyes@fhemberger