Skip to content

Update what-are-the-built-in-timer-functions.md - #2074

Merged
3 commits merged into
nodejs:masterfrom
Yash-Handa:timer-functions
Feb 14, 2019
Merged

Update what-are-the-built-in-timer-functions.md#2074
3 commits merged into
nodejs:masterfrom
Yash-Handa:timer-functions

Conversation

@Yash-Handa

Copy link
Copy Markdown
Contributor

Hey @chowdhurian and @fhemberger,
In accordance with issue #1977, I have updated the Article how-to-prompt-for-command-line-input with the following changes:

  • Added setImmidiate() with example
  • some other miscellaneous updates and refactors.

If there are any suggestion/enhancement/tips please feel free to tell me, I would love to incorporate those changes in this Article 😄

NOTE: Let me know if process.nextTick should be added as it is technically not a timing function.

@ZYSzysZYSzys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keywordnewkeywordnew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me! Really good updates here 🎉

I added an update to an untouched part of the document. Piggybacking on this PR to land the correction if that's ok :)

…in-timer-functions.md
Made some language (English) updates. For better understanding
Co-Authored-By: Yash-Handa <yashhanda7@yahoo.com>
@ghost
ghost merged commit fb5a2bf into nodejs:masterFeb 14, 2019
@ghost

Copy link
Copy Markdown

@Yash-Handa: Thanks!

This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Yash-Handa@fhemberger@keywordnew@ZYSzys