Skip to content

PT-BR/Translation for what-is-json.md (@thierrysantoos1) - #2287

Merged
5 commits merged into
nodejs:masterfrom
0xthierry:master
Jun 29, 2019
Merged

PT-BR/Translation for what-is-json.md (@thierrysantoos1)#2287
5 commits merged into
nodejs:masterfrom
0xthierry:master

Conversation

@0xthierry

@0xthierry0xthierry commented Jun 23, 2019•
edited by ghost
Loading

Copy link
Copy Markdown
Contributor

Hi everyone,

This PR translates to portuguese the page what-is-json.md.
The javascript-conventions folder were created for the translated file.

@nodejs/nodejs-pt：Would you mind helping to have a review？

khaosdoctor
khaosdoctor requested changes Jun 24, 2019
View reviewed changes

@khaosdoctorkhaosdoctor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos

Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
Comment threadlocale/pt-br/knowledge/javascript-conventions/what-is-json.md Outdated
@glaucia86glaucia86 mentioned this pull request Jun 24, 2019
Closed
0xthierryand others added 4 commits June 24, 2019 19:02
@0xthierry@khaosdoctor
Update locale/pt-br/knowledge/javascript-conventions/what-is-json.md
c98edc7
Co-Authored-By: Lucas Santos <lhs.santoss@gmail.com>
@0xthierry@khaosdoctor
Update locale/pt-br/knowledge/javascript-conventions/what-is-json.md
f68aa45
Co-Authored-By: Lucas Santos <lhs.santoss@gmail.com>
@0xthierry@khaosdoctor
Update locale/pt-br/knowledge/javascript-conventions/what-is-json.md
7be99b4
Co-Authored-By: Lucas Santos <lhs.santoss@gmail.com>
@0xthierry@khaosdoctor
Apply suggestions from code review
935ef20
Co-Authored-By: Lucas Santos <lhs.santoss@gmail.com>
@0xthierry

0xthierry commented Jun 24, 2019

Copy link
Copy Markdown
ContributorAuthor

Hi, I have fixed right now.

khaosdoctor
khaosdoctor approved these changes Jun 26, 2019
View reviewed changes

@khaosdoctorkhaosdoctor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@khaosdoctor

khaosdoctor commented Jun 26, 2019

Copy link
Copy Markdown
Member

cc: @Maledong @Trott

@ghostghost closed this Jun 27, 2019
@ghostghost reopened this Jun 29, 2019
@ghost
ghost merged commit db55233 into nodejs:masterJun 29, 2019
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaosdoctorkhaosdoctorkhaosdoctor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xthierry@khaosdoctor