Skip to content

Blog: Fix v8.dev link in v12.5.0 release post - #2300

Merged
2 commits merged into
nodejs:masterfrom
Cherry:fix-external-v8-link
Jun 29, 2019
Merged

Blog: Fix v8.dev link in v12.5.0 release post#2300
2 commits merged into
nodejs:masterfrom
Cherry:fix-external-v8-link

Conversation

@Cherry

Copy link
Copy Markdown
Contributor

This fixes the v8.dev link to not act as a relative URL in https://nodejs.org/en/blog/release/v12.5.0/. Currently in links to https://nodejs.org/en/blog/release/v12.5.0/v8.dev/features/numeric-separators, but this PR fixes it to https://v8.dev/features/numeric-separators

@devsnek

Copy link
Copy Markdown
Member

thank you! would you mind also adding links to the notable changes' prs? see https://github.com/nodejs/node/pull/28450/files

@Cherry

Copy link
Copy Markdown
ContributorAuthor

Done, thanks 👍

@ghost
ghost merged commit adefe8b into nodejs:masterJun 29, 2019
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Cherry@devsnek