Uh oh!
There was an error while loading. Please reload this page.
Assorted link fixes. - #2563
Conversation
XhmikosR
commented
Sep 13, 2019
Can we move forward with this? |
Trott
commented
Sep 13, 2019
It's not clear to me that Anyway, not opposing this or anything. Just explaining why I haven't offered an opinion. I'm not sufficiently informed about current best practices etc. Let's ping @nodejs/website and see if people can approve or explain why not. Feel free to open a smaller PR with just a few of these if there are some that are obvious slam-dunk must-change links so that they aren't held up by other links that perhaps need discussion. |
XhmikosR
commented
Sep 14, 2019
The missing trailing slash is a useless redirect. |
XhmikosR
commented
Sep 14, 2019
I fixed more links. There's probably even more but I want to do it in batches and also we need #2565 eventually. |
XhmikosR
commented
Sep 15, 2019
OK, this is done. I don't want to push more stuff to keep it easier to review. The only thing that I'm not sure is what's the policy to linking to translated files. I mean, I know in production we generate all the missing files from translations, but linking to them isn't consistent AFAICT. So, for the time being, I only link to translated pages. |
Trott
commented
Sep 15, 2019
Lots of files changed, but fewer than 300 lines. Anyone up for reviewing this? @nodejs/website (I'd hate to ask @XhmikosR to split this into multiple PRs to make reviewing easier but if that's what we gotta do to get some folks to review it sufficiently, then so be it.) |
There was a problem hiding this comment.
Why do you changed translation?
There was a problem hiding this comment.
Because there's no /faq link and I don't speak ca.
Uh oh!
There was an error while loading. Please reload this page.
* use relative to root URLs for files generated in this repo * use the absolute URL for all other URLs * fix 404s
There's probably a lot more...
But in order to speed things up, we need to make any doc links relative to the server root when possible, and use the absolute URLs only for files that are not generated in this repo.
For example,
https://nodejs.org/en/blog/should become/en/blog/. Being that this change will be a big one, I first need confirmation before moving with it.I've managed to scan for internal links for the English version in my linkinator branch. Travis CI build: https://travis-ci.org/XhmikosR/nodejs.org/builds/582621043
There's one failure only due to #2422, which I'm unsure how to solve.
That being said, if we agree on the relative vs absolute links, I'll make a PR with linkinator so that others can chime in and help.