Uh oh!
There was an error while loading. Please reload this page.
linting - #270
Merged
Merged
Conversation
stevemao
commented
Oct 21, 2015
ContributorAuthor
stevemao
commented
Oct 22, 2015
ContributorAuthor
@fhemberger do you have any idea why |
fhemberger
commented
Oct 22, 2015
Contributor
No, not really. Might be we ran into an edge case here. |
stevemao
commented
Oct 22, 2015
ContributorAuthor
😞 |
phillipj
commented
Oct 22, 2015
Member
Huh, that's strange! Our use of pre-commit should have prevented my commiting linting errors and Travis should have warned ofc.. 💥 |
fhemberger
commented
Oct 23, 2015
Contributor
@phillipj Same issue with #259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
056cddf test fails because of linting. I don't know why it passed for the previous commits.