Skip to content

[ru] translation of dockerizing node.js app guide - #2743

Merged
Trott merged 4 commits into
nodejs:masterfrom
kauz:translate-guide-docker
Nov 5, 2019
Merged

[ru] translation of dockerizing node.js app guide#2743
Trott merged 4 commits into
nodejs:masterfrom
kauz:translate-guide-docker

Conversation

@kauz

@kauzkauz commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@nschonni

nschonni commented Nov 5, 2019

Copy link
Copy Markdown
Member

Ping @nodejs/nodejs-ru

alexandrtovmach
alexandrtovmach suggested changes Nov 5, 2019
View reviewed changes

@alexandrtovmachalexandrtovmach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо за ваш вклад, оставил пару замечаний.
Из общего:

  • Node.js это единственно правильное написание, никаких маленьких букв и т.д.
  • Docker аналогично, только с большой
  • обращения "вы" и "вам" пишутся с маленькой

Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
@kauz
kauzforce-pushed the translate-guide-docker branch from c0dd6ef to f7f0aa8CompareNovember 5, 2019 08:41
alexandrtovmach
alexandrtovmach suggested changes Nov 5, 2019
View reviewed changes

@alexandrtovmachalexandrtovmach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну не совсем всё исправлено

Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
Comment threadlocale/ru/docs/guides/nodejs-docker-webapp.md Outdated
@kauz@alexandrtovmachArtyom Popov
Apply suggestions from code review
11d84b6
Co-Authored-By: Alexandr Tovmach <alexandrtovmach@gmail.com>
@kauz
kauzforce-pushed the translate-guide-docker branch 2 times, most recently from 14d34db to 3e610aaCompareNovember 5, 2019 10:00
@kauz@alexandrtovmachArtyom Popov
Apply suggestions from code review
d825a38
Co-Authored-By: Alexandr Tovmach <alexandrtovmach@gmail.com>
@kauz
kauzforce-pushed the translate-guide-docker branch from 3e610aa to d825a38CompareNovember 5, 2019 10:10
@Trott
Trott merged commit d94b428 into nodejs:masterNov 5, 2019
@NOUIYNOUIY mentioned this pull request Apr 14, 2023
Open
@snyk-botsnyk-bot mentioned this pull request Jun 1, 2023
Open
@jydmykjydmyk mentioned this pull request Jun 5, 2023
Open
@kingjay66kingjay66 mentioned this pull request Oct 14, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@alexandrtovmachalexandrtovmachalexandrtovmach approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kauz@nschonni@alexandrtovmach@Trott