Skip to content

Black Lives Matter - #3202

Merged
MylesBorins merged 43 commits into
masterfrom
black-lives-matter
Jun 4, 2020
Merged

Black Lives Matter#3202
MylesBorins merged 43 commits into
masterfrom
black-lives-matter

Conversation

@bnb

@bnbbnb commented Jun 2, 2020

Copy link
Copy Markdown
Contributor

This PR adds a new handlebars template and sets index.md to use it. The intent (as discussed with the @nodejs/tsc and @nodejs/community-committee) is to redirect most/all pages to this page for a duration of 7 days from being moved into production. In local testing, this successfully set the main page of the english site to this (I presume we'd want to redirect all languages to this page rather than editing them all).

The template is not intended to be locked and can absolutely be modified - to add more names, to add more lists of Black people who have been murdered by the police, to add more TSC and CommComm names to the list of folks to reach out to, and to tweak phrasing/approach based on feedback.

Black Lives Matter.

@bnbbnb changed the title feat: add black-lives-matter.hbs and use it on index.mdBlack Lives MatterJun 2, 2020

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nits

Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs Outdated
…names to the lsit
Co-authored-by: Black Lives Matter <mylesborins@google.com>

@joesepijoesepi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Comment threadlayouts/black-lives-matter.hbs
Comment threadlayouts/black-lives-matter.hbs Outdated
@bnb

bnb commented Jun 2, 2020

Copy link
Copy Markdown
ContributorAuthor

Please don't merge yet.

Comment threadlocale/en/index.md

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MylesBorins

Copy link
Copy Markdown
Contributor

@bnb my understanding from testing this locally is that there are no redirects. All deep links on the website will continue to work exactly the way the have prior to this PR.

This is likely preferred, as taking down nodejs.org/downloads would break node-gyp and a chunk of the internet.

Comment threadlayouts/black-lives-matter.hbs
Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs
Comment threadlayouts/black-lives-matter.hbs Outdated
Comment threadlayouts/black-lives-matter.hbs Outdated
bnband others added 2 commits June 4, 2020 13:56
Comment threadlayouts/black-lives-matter.hbs
Comment threadlayouts/black-lives-matter.hbs Outdated
I'll also love to show my support for African Americans. ✊🏿
Co-authored-by: Myles Borins <mylesborins@google.com>
Comment threadlayouts/black-lives-matter.hbs Outdated
MylesBorinsand others added 2 commits June 4, 2020 14:37
Comment threadlayouts/black-lives-matter.hbs Outdated
@bnb

bnb commented Jun 4, 2020

Copy link
Copy Markdown
ContributorAuthor

:shipit:

Comment threadlayouts/black-lives-matter.hbs
Co-authored-by: Tierney Cyren <accounts@bnb.im>
@MylesBorins
MylesBorins merged commit 2750705 into masterJun 4, 2020
@MylesBorins
MylesBorins deleted the black-lives-matter branch June 4, 2020 20:05
@sxasxa mentioned this pull request Jun 5, 2020
@nodejsnodejs locked as resolved and limited conversation to collaborators Jun 5, 2020
@MylesBorins

MylesBorins commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

I've locked this PR as the discussion has resolved and the update to the main page has landed.

As mentioned in the original post this decision was made with buy-in from both the TSC and the CommComm

More details about our response can be found here

#3229

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

20 participants

@bnb@MylesBorins@nschonni@sxa@joesepi@jasnell@ljharb@mcollina@fhinkel@ChALkeR@yosuke-furukawa@Trott@addaleax@boneskull@wesleytodd@obensource@codebytere@cjihrig@tniessen@hiroppy