Skip to content

A small set of design changes - #33

Closed
joarwilk wants to merge 5 commits into
nodejs:masterfrom
joarwilk:design-changes
Closed

A small set of design changes#33
joarwilk wants to merge 5 commits into
nodejs:masterfrom
joarwilk:design-changes

Conversation

@joarwilk

Copy link
Copy Markdown

Here's a small group of changes that improves readability across the site, I'll wait with doing more until I know it's needed right now. Would love to help out.

Comment threadlayouts/css/base.styl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm, I think some base styles were lost from io.js here.

I suggest:

html-webkit-font-smoothingantialiased-moz-osx-font-smoothinggrayscale-webkit-font-variant-ligaturesnonefont-variant-ligaturesnone

Please remove text-rendering optimizeLegibility for text that isn't fairly large. It is very slow and can negatively impact page load times.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I didnt copy everything, was just a couple of base additions. I'll move the text rendering to headers only.

@fhemberger

Copy link
Copy Markdown
Contributor

Closing this:

  • -webkit-font-smoothing: antialiased decreases legibility on OS X because of the thin font.
  • We don't want to decrease the base font size
  • Web fonts were added via Google web fonts in the mean time.

@Fishrock123

Copy link
Copy Markdown
Contributor

-webkit-font-smoothing: antialiased decreases legibility on OS X because of the thin font.

I think you will find a good amount people who disagree with that... is the text we are using currently too small?

@fhemberger

Copy link
Copy Markdown
Contributor

Without -webkit-font-smoothing: antialiased on Chrome/OS X:

With -webkit-font-smoothing: antialiased on Chrome/OS X:

@mikeal

Copy link
Copy Markdown
Contributor

what if we increase the default weight and do -webkit-font-smoothing: antialiased?

@Fishrock123

Copy link
Copy Markdown
Contributor

what if we increase the default weight and do -webkit-font-smoothing: antialiased?

Yeah I was going to suggest something like this so that we can use the below, like io.js:

html-webkit-font-smoothingantialiased-moz-osx-font-smoothinggrayscale-webkit-font-variant-ligaturesnonefont-variant-ligaturesnone

Generally you'll end up with more balanced text after that from my understanding.

@fhemberger

Copy link
Copy Markdown
Contributor

I'm fine with trying a different weight, let's see how it turns out. With autoprefixer in the build pipeline, we should be able to drop any custom prefixes. Is there a reason to drop ligatures?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joarwilk@fhemberger@Fishrock123@mikeal