Use fs.access instead of fs.existsSync

[lpinca]

The reason behind this change is that fs.exists and its sync version are deprecated.

[thefourtheye]

Since you are refactoring, you can directly create evRepo without those intermediate requires.

[lpinca]

Sure.

[thefourtheye]

Change LGTM. Do you know why CI is not run for this PR?

[lpinca]

No clue.

[lpinca]

@thefourtheye please check again.

[phillipj]

LGTM. Some error handling on the HTTPS request and file writing would be nice, but that could be another PR.

[thefourtheye]

Would it be better if we notified the user once the downloading is complete?

[lpinca]

Any idea on what kind of message? Something like this?

console.log(`Weekly Update ${filePath} downloaded.`);

[thefourtheye]

We already log the filePath. So wouldn't Download completed be better?

[lpinca]

It would help to understand what file the message refers to, otherwise with multiple files, it can be confusing, but yes a simple "Download completed" can work too.

[thefourtheye]

@phillipj do you know why CI is not run for this PR?

[lpinca]

@thefourtheye If you feel strong about using only "Download completed.", I'll change this.

[thefourtheye]

This actually should have been

response.on('end',()=>console.log(`Weekly Update ${filePath} downloaded.`))

[phillipj]

@thefourtheye no idea why it doesn't show inline in the PR.. These commits are visible in the Travis/new.nodejs.org build history though, might be a github hickup?

[lpinca]

PTAL.

[thefourtheye]

Still looks fine to me. But I would be confident if CI ran.

[phillipj]

https://travis-ci.org/nodejs/new.nodejs.org/builds/90492242 is the build for @lpinca latest commit ba338a5

[thefourtheye]

Cool. Merged now. 👍 Thanks @phillipj :-)