Uh oh!
There was an error while loading. Please reload this page.
Add Node.js on Docker guide - #366
Conversation
fhemberger
commented
Nov 18, 2015
Nice, looking forward to it! |
ghost
commented
Nov 18, 2015
added some minor nitpicks, but otherwise it looks nice |
rnsloan
commented
Nov 18, 2015
Worth mentioning towards the bottom that if you want to enter the container to take a look around you can with the |
retrohacker
commented
Nov 18, 2015
This is super slick @Starefossen :-) I have a similar writeup here for both Docker and docker-compose: https://nodesource.com/blog/dockerizing-your-nodejs-applications |
retrohacker
commented
Nov 18, 2015
I have been thinking about turning this into a blog post for a while. Perhaps it would make a better wiki? I'd like to see something focused on using Docker and docker-compose for local dev. If you think this is a good fit, I'll draft something up 😄 |
59e32fc to
0e61c79CompareStarefossen
commented
Nov 19, 2015
Thanks for good feedback! I have updated the guide with everything suggested so far. There are two todos lest; intro to docker and where to get help. @wblankenship I have not had Node installed on my computer for the past year, I have been running everything through Docker Compose! I feel Compose may be a bit much/advanced for this guide, I would definitely like to see that go into a wiki or a separate guide! |
There was a problem hiding this comment.
Suggestions:
- official documentation: https://docs.docker.com/
- docker tag on stack overflow: http://stackoverflow.com/questions/tagged/docker
- docker subreddit: https://reddit.com/r/docker
There was a problem hiding this comment.
Thanks for the suggestions @rnsloan. I have pushed a new version.
0e61c79 to
d6e813fCompareStarefossen
commented
Nov 23, 2015
I am pretty happy with the current version of the Node.js on Docker guide now. Please, nitpick and correct my spelling mistakes if you find anything, and post your suggestions on how to improve this guide. // cc @nodejs/docker |
There was a problem hiding this comment.
use ```bash instead of indentation?
d6e813f to
ebe46adCompareSigned-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
ebe46ad to
5308fc3CompareStarefossen
commented
Nov 27, 2015
Well, I guess all the suggestions and feedback have been resolved. It should be good to merge now :) |
phillipj
commented
Nov 27, 2015
It would be a shame if we didn't link to this anywhere. Guess adding a link in our guides section |
Starefossen
commented
Nov 27, 2015
Isn't that done automatic: Line 110 in 26e4fe0 |
phillipj
commented
Nov 27, 2015
Sorry, forgot guides was made as a collection. |
phillipj
commented
Nov 27, 2015
Thanks! 👍 |
A simple guide to show the user how to get a Node.js application running in a Docker container using the official Docker Image for Node.js. It assumes a working installation of Docker and rootamentary understanding of how a Node.js application is structured.
This is based on the Node.js Web App guide at doc.docker.com.
// cc @nodejs/docker