Uh oh!
There was an error while loading. Please reload this page.
Conversation
XhmikosR
marked this pull request as ready for review
December 21, 2021 06:54
XhmikosR
enabled auto-merge (squash)
December 21, 2021 06:54
aymen94
approved these changes
Feb 18, 2022
Trott
commented
Mar 8, 2022
Member
@XhmikosR Do you want to rebase so this can be landed? |
XhmikosR
commented
Mar 8, 2022
ContributorAuthor
I'm not sure this PR makes sense anymore... I mean, I see pretty modern features being used like |
Member
@XhmikosR I think not make sense. |
XhmikosR
commented
Mar 8, 2022
ContributorAuthor
Either way, .browserslistrc should be updated and |
aymen94
commented
Mar 8, 2022
Member
@XhmikosR yes, we can update it by making a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Later, we should enforce const/let properly. This patch just streamlines the code with what we are currently using.