Skip to content

package.json: add missing properties - #4323

Merged
nschonni merged 2 commits into
mainfrom
XhmikosR-patch-1
Dec 28, 2021
Merged

package.json: add missing properties#4323
nschonni merged 2 commits into
mainfrom
XhmikosR-patch-1

Conversation

@XhmikosR

@XhmikosRXhmikosR commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

npm init (using npm 8.1.3) is using the explicit repository and bugs properties but I guess it was intentional to skip them? If not, let me know so that I add them:

"repository": {
"type": "git",
"url": "git+https://github.com/nodejs/nodejs.org.git"
},
"bugs": {
"url": "https://github.com/nodejs/nodejs.org/issues"
},

@XhmikosR
XhmikosR marked this pull request as ready for review December 28, 2021 18:51
@XhmikosR
XhmikosR requested a review from a team as a code ownerDecember 28, 2021 18:51
@nschonni

Copy link
Copy Markdown
Member

Kinda -0, since this is an unpublished package, so I don't think these are really needed

@XhmikosR

XhmikosR commented Dec 28, 2021

Copy link
Copy Markdown
ContributorAuthor

I agree, but I personally keep the defaults. I noticed it recently here: #4322 (comment)

npm ERR! While resolving: nodejs.org@undefined

Either way, I'm fine with dropping the patch, I just happened to notice this.

@Trott

Copy link
Copy Markdown
Member

Totally neutral on this one. Happy if it lands, happy if we close it. Whichever.

@nschonni
nschonni merged commit 58c1db3 into mainDec 28, 2021
@nschonni
nschonni deleted the XhmikosR-patch-1 branch December 28, 2021 22:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@XhmikosR@nschonni@Trott