Skip to content

copyedit profiling guide - #446

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:copyedit-profile-guide
Closed

copyedit profiling guide#446
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:copyedit-profile-guide

Conversation

@Trott

@TrottTrott commented Jan 5, 2016

Copy link
Copy Markdown
Member

No description provided.

@lpinca

lpinca commented Jan 6, 2016

Copy link
Copy Markdown
Member

LGTM.

@stevemao

stevemao commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

Maybe leave a reference of where this is copied from?

fhemberger
fhemberger reviewed Jan 6, 2016
View reviewed changes
Comment threadlocale/en/docs/guides/simple-profiling.md

@fhembergerfhembergerJan 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous space in command

@fhemberger

fhemberger commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

@stevemao It's the exact same text as before (with adjusted wrapping) and new "isolate-0xnnnnnnnnnnnn-v8.log (where n is a digit)".

@stevemao

stevemao commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

Oh from the commit message I thought it was copied from somewhere.

@Trott

Trott commented Jan 6, 2016

Copy link
Copy Markdown
MemberAuthor

@stevemao I was using copyedit in this context: https://en.wikipedia.org/wiki/Copy_editing

I use that word a lot in my commit messages (when I'm fixing typos, punctuation, formatting, etc.) but if it's confusing to a lot of people, I can try to use a synonym instead.

@stevemao

stevemao commented Jan 6, 2016

Copy link
Copy Markdown
Contributor

@Trott It's Ok I guess. My English is very bad 😄

evanlucas
evanlucas reviewed Jan 7, 2016
View reviewed changes
Comment threadlocale/en/docs/guides/simple-profiling.md

@evanlucasevanlucasJan 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, should we also mention the --prof-process flag now?

@matthewloringmatthewloring mentioned this pull request Jan 8, 2016
Closed
@fhemberger

fhemberger commented Jan 9, 2016

Copy link
Copy Markdown
Contributor

Merged via 6a61f69, thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@lpinca@stevemao@fhemberger@evanlucas