Skip to content

guide: add user journey memory tutorial - #4728

Merged
RafaelGSS merged 3 commits into
nodejs:mainfrom
RafaelGSS:feat/include-memory-diagnostics
Jul 20, 2022
Merged

guide: add user journey memory tutorial#4728
RafaelGSS merged 3 commits into
nodejs:mainfrom
RafaelGSS:feat/include-memory-diagnostics

Conversation

@RafaelGSS

@RafaelGSSRafaelGSS commented Jul 17, 2022

Copy link
Copy Markdown
Member

Reference: nodejs/diagnostics#502

The Node.js Diagnostics Working Group has been creating a collection of tutorials for the past 3 years (?).

The goal is to track the user journey across various issues and provide a good reference that users can use as a baseline when diagnosing a codebase.

Those tutorials were created some time ago. We did a review, but things move fast and it might be out-of-date at some point.

cc: @nodejs/diagnostics

@RafaelGSS
RafaelGSS marked this pull request as ready for review July 17, 2022 21:40
@tony-go

tony-go commented Jul 18, 2022

Copy link
Copy Markdown
Member

Hey @RafaelGSS 👋

Neat!

What is the strategy here? Should we take time to review the whole content, or should we merge it quickly and then improve it incrementally?

@RafaelGSS

RafaelGSS commented Jul 18, 2022

Copy link
Copy Markdown
MemberAuthor

Hey @RafaelGSS 👋

Neat!

What is the strategy here? Should we take time to review the whole content, or should we merge it quickly and then improve it incrementally?

The idea is to review the whole content, so we make sure we aren't delivering an out-of-date content to end users

Qard
Qard reviewed Jul 18, 2022
View reviewed changes

@QardQard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a few minor nits.

Comment threadlocale/en/docs/guides/diagnostics/index.md
Comment threadlocale/en/docs/guides/diagnostics/index.md Outdated
Comment threadlocale/en/docs/guides/diagnostics/memory/using-gc-traces.md Outdated
gireeshpunathil
gireeshpunathil reviewed Jul 18, 2022
View reviewed changes
Comment threadlocale/en/docs/guides/diagnostics/memory/using-gc-traces.md Outdated
Comment threadlocale/en/docs/guides/diagnostics/memory/using-gc-traces.md Outdated
Comment threadlocale/en/docs/guides/diagnostics/memory/using-gc-traces.md Outdated
Comment threadlocale/en/docs/guides/diagnostics/memory/using-heap-snapshot.md Outdated
Comment threadlocale/en/docs/guides/diagnostics/memory/using-heap-snapshot.md Outdated
tony-go
tony-go reviewed Jul 19, 2022
View reviewed changes
Comment threadlocale/en/docs/guides/diagnostics/memory/index.md
Comment threadlocale/en/docs/guides/diagnostics/memory/index.md
@RafaelGSS
RafaelGSS requested a review from mhdawsonJuly 19, 2022 17:27
mhdawson
mhdawson reviewed Jul 19, 2022
View reviewed changes
Comment threadlocale/en/docs/guides/diagnostics/memory/using-gc-traces.md Outdated
mhdawson
mhdawson reviewed Jul 19, 2022
View reviewed changes
Comment threadlocale/en/docs/guides/diagnostics/memory/using-gc-traces.md Outdated
mhdawson
mhdawson reviewed Jul 19, 2022
View reviewed changes
Comment threadlocale/en/docs/guides/diagnostics/memory/using-heap-profiler.md Outdated
mhdawson
mhdawson approved these changes Jul 19, 2022
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few small suggestions.

@RafaelGSS
RafaelGSSforce-pushed the feat/include-memory-diagnostics branch 3 times, most recently from b846b21 to 7168854CompareJuly 19, 2022 22:39
@RafaelGSS
RafaelGSSforce-pushed the feat/include-memory-diagnostics branch from 7168854 to 2efaaf6CompareJuly 20, 2022 12:19
@RafaelGSS
RafaelGSS enabled auto-merge (squash) July 20, 2022 12:19
@RafaelGSS
RafaelGSS merged commit 8ee959d into nodejs:mainJul 20, 2022
@ghostghost mentioned this pull request Jul 22, 2022
Merged
ghost pushed a commit that referenced this pull request Jul 23, 2022
Maledong
zh-CN: 'Diagnostics' translations (#4735)
40b6e30
Refs: #4728
@RafaelGSSRafaelGSS mentioned this pull request Jul 26, 2022
Open
27 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QardQardQard approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
+1 more reviewer
@tony-gotony-gotony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelGSS@tony-go@Qard@gireeshpunathil@mhdawson