Uh oh!
There was an error while loading. Please reload this page.
feat(infra): migrate to next.js infrastructure - #4981
Closed
ovflowd wants to merge 20 commits into
Closed
Conversation
added 16 commits
December 23, 2022 11:28
| @@ -1,5 +1,3 @@ | |||
| # Generated HTML and other static files | |||
| build/ | |||
There was a problem hiding this comment.
Claudio does not forget the .next (it is not a priority)
ovflowd
commented
Jan 3, 2023
MemberAuthor
Closing this PR in favor of #4991 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a draft to migrate the underlying infrastructure from Handlebars and Metalsmith to JSX (React) and Next.js.
Changes
Legacy Content Removal
The items above are considered legacy content and pages.
Migration of Structure
A few directories are changed to accommodate the new Next.js folder structure. Notably, these are the significant changes:
src/componentssrc/styleslocale/{languageCode}/{folder}/{filename}.mdtopages/{folder}/{filename}.{languageCode}.mdx(Plain.mdwhen no React Component is needed)static/topublic/static(Links will be preserved)src/layoutssrc/datasrc/i18nThe deletion of per-locale
site.jsonand creation of a globalsite.jsoni18n specific metatdata will be moved to
src/i18n/locales.jsonas the aggregate of all i18n metadata. Specific translation texts (such as "Next" button) or other translated text will be moved toi18nlocalization files such assrc/i18n/locales/en.json. This is the same approach adopted currently onnodejs.devrepository to ease the migration.Navigation structure and other non-related global metadata will be moved towards a global
src/data/site.jsonand respectively for Navigation topages/_meta.jsonfiles.Migration of Handlebars Templates to JSX
A lot of the current "Handlebars" scripts (for templating-engine) will be ported to either JavaScript utils or JSX Components, and the current Layouts will be ported to JSX too.
Things to be done (Within this PR)
Since this PR is in a draft state, there are still a few things to be done before we can say we're ready to get this PR reviewed:
locale/pages to the new directory and file structure formatpagesfolder and new file format and update its FrontmatterMigration from old tooling/scripts
Currently, we have scripts to generate the metadata of releases, versions, and the release schedule of Node.js; we should adopt the nodes from Nodejs.dev as they're going to be adopted anyways. This can be done either in this PR or in a follow-up, depending on the complexity of migrating the current scripts.
Open Questions
Items to be done after this PR
As mentioned, this is an initial implementation for this issue, following-up there will still be some improvements to be done, such as removing more legacy content and normalizing the JSX code and a few other things.
After that, we can start porting the layout and content from the Nodejs.dev repository.
Relates to #4958
cc @nodejs/website @nodejs/nodejs-dev @nodejs/build