fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix: windows 11 cannot detect CPU processor successfully - #5125

Merged
6 commits merged into
mainfrom
unknown repository
Mar 17, 2023
Merged

fix: windows 11 cannot detect CPU processor successfully#5125
6 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghostghost commented Mar 14, 2023

Copy link
Copy Markdown

@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown
Author

@styfle or @ovflowd：Could any of you have free time to review it?

ovflowd
ovflowd requested changes Mar 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent is great, but the code is messy and kinda hard to read, I added a comment with a better example.

Comment threadpublic/static/js/legacyMain.js Outdated
Comment threadpublic/static/js/legacyMain.js
Comment threadpublic/static/js/legacyMain.js Outdated
@ovflowdovflowd mentioned this pull request Mar 14, 2023
Closed
@ghost

ghost commented Mar 14, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd : Thanks for your patience to add up a lot of things missing in the rough codes, however there're still some things to discuss :)

styfle
styfle reviewed Mar 14, 2023
View reviewed changes
Comment threadpublic/static/js/legacyMain.js Outdated
MaledongGit added 2 commits March 15, 2023 10:30
MaledongGit
fix: windows 11 cannot detect CPU processor successfully
6383e83
Refs:
1. #5028.
2. #5025.
Due to the author doesn't have free time to fix this, I'd like to help.
Maledong
Merge branch 'main' into addCustomizedPageHandle
66b42c1
@ghost
ghost requested review from ovflowd and styfleMarch 15, 2023 02:32
ovflowd
ovflowd approved these changes Mar 15, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

@ovflowd

ovflowd commented Mar 15, 2023

Copy link
Copy Markdown
Member

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible 🙃

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Btw: @MaledongGit don't forget to test this on Firefox and Chrome on Windows if possible

No problem. I have Windows 10 with latest FF, Chrome and IE.

@styfle : If you have Windows 11, can you help to test it?

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd & @styfle：

Firstly, FF and Chrome go fine with me now. I think everything goes fine with me now on Win 10.

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

image

In the end, just waiting for @styfle 's tests on Win 11 for FF/Chrome.

@ghost

ghost commented Mar 16, 2023•
edited by ghost
Loading

Copy link
Copy Markdown
Author

@ovflowd：Should we alert a message or something similar to notify those using IE browser to change to Edge/Chrome/FF? Because they won't work properly for Node.js loading and they are totally out of service?

Another way is to put something like polyfill.js to be compatable with IE, but is it possible to do so? IE's is out of its way.

If you think possible, maybe this will be done later.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown
Author

Hey @MaledongGit thanks for the changes, and I also appreciate the patience with dealing with me 🙈🫠 I know my communication at times can sound off or harsh, but I swear, have the best of intentions here ❤️

Let's get this merged!

Nothing special, that's THE REAL TALK sincerely, problems and ideas may occur here.
Glad to share this time with you!!!! XD XD

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

Secondly, notice that IE 11 doesn't support new js functions or properties...ect, when debugging locally, but it doens't matter when keeping these codes, because IE11 is out of service by Microsoft for Edge. And now if someone tends to use IE11 on Windows 10, it will directly guide you to the Edge download page, which means you cannot use IE11 in normal or smoothly. Have u noticed that on the latest version of IE11 and windows 10?

We can add support to IE11 through https://nextjs.org/docs/basic-features/supported-browsers-features#browserslist, but I wonder @Trott should we actually still support IE11? I can imagine people downloading Node.js through Windows Server or older machines, so I assume, yes?

@MaledongGit if you want, feel free to make a PR with a Browserlist config that includes IE11 :)

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

@ovflowd

ovflowd commented Mar 16, 2023

Copy link
Copy Markdown
Member

I use a VM to test windows. Is there a vercel preview deployment url we can use to test? I'm not seeing it on this PR?

We don't use Vercel yet.

@styfle

styfle commented Mar 16, 2023

Copy link
Copy Markdown
Member

We don't use Vercel yet.

I see. Let me know if you need any help setting it up 👍

In the meantime, I deployed this branch here https://nodejs-2jdiq6e4o-uncurated-tests.vercel.app/en

I also confirmed it works on Windows 11 64 bit ARM on Edge, Chrome, and Firefox ✅

@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown
Author

Thanks for both, I first merged this bug fix and I'll submit another new PR to support IE when free :)

@ghost
ghost merged commit 001bdcb into nodejs:mainMar 17, 2023
@ghost
ghost deleted the addCustomizedPageHandle branch March 17, 2023 01:38
This pull request was closed.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@styfle