Skip to content

Blog: v20.1.0 release post - #5352

Merged
targos merged 1 commit into
nodejs:mainfrom
targos:v20.1.0
May 3, 2023
Merged

Blog: v20.1.0 release post#5352
targos merged 1 commit into
nodejs:mainfrom
targos:v20.1.0

Conversation

@targos

Copy link
Copy Markdown
Member

@targos
targos requested a review from a team as a code ownerMay 3, 2023 15:46
@vercel

vercelBot commented May 3, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
NameStatusPreviewCommentsUpdated (UTC)
nodejs-org⬜️ Ignored (Inspect)May 3, 2023 3:47pm
nodejs-org-stories⬜️ Ignored (Inspect)May 3, 2023 3:47pm

@targos
targos enabled auto-merge (squash) May 3, 2023 15:49
@targos
targos merged commit 7cccb76 into nodejs:mainMay 3, 2023
@targos

Copy link
Copy Markdown
MemberAuthor

Needs two approving reviews? That may be a problem sometimes (blog post should be published ASAP after the release is promoted).

@targos
targos deleted the v20.1.0 branch May 3, 2023 15:55
@ovflowd

Copy link
Copy Markdown
Member

@targos we can create bypass rules for releasers.

@targos

Copy link
Copy Markdown
MemberAuthor

Can we bypass only this rule? I don't want to bypass CI workflows.

@ovflowd

ovflowd commented May 3, 2023

Copy link
Copy Markdown
Member

Which rule? (Amount of reviewers?)

@targos

Copy link
Copy Markdown
MemberAuthor

Yes, amount of reviewers.

@ovflowd

Copy link
Copy Markdown
Member

I don't think there's bypass for an individual requirement. Let me check on OpenJS Slack.

@targos

Copy link
Copy Markdown
MemberAuthor

If necessary, we can create a separate ruleset for this requirement. btw GitHub deployed a new way to define rules recently: https://github.com/nodejs/nodejs.org/settings/rules

@ovflowd

Copy link
Copy Markdown
Member

I applied a few rules, @targos! Let's check if next time they work well!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@targos@ovflowd@BethGriggs