css: newsletter-signup

[LoganArnett]

Found this in relation to #57, the iframe for the newsletter signup has a large amount of empty whitespace underneath it with a default height="500" on both desktop and mobile. Just changed to max-height to avoid this.

[ghost]

Travis build passed 👍

[williamkapke]

Is this related to #578?

[LoganArnett]

@williamkapke I dont believe so, this is for when the form is present not after it has been filled out and disappears

[lpinca]

@LoganArnett what you are doing here is changing the HTML height attribute to max-height which is not a valid HTML attribute.

With this change the iframe will display with its default height which is 150px.
This is not sufficient to display the full iframe contents on screens which are between 480px and 580px wide unless we are ok to have a vertical scroll bar.

Setting max-height in the style attribute also does not help.

That said, reducing the current value from 500 to 300 should be safe and partially fix the issue.

[LoganArnett]

Yea I do not know why I changed it that way, yesterday was a long day haha I can update it to the 300px

[lpinca]

LGTM.

[ghost]

yup, LGTM from me as well