Uh oh!
There was an error while loading. Please reload this page.
Make footer look better on mobile - #63
Merged
Merged
Conversation
fhemberger
commented
Aug 30, 2015
Contributor
@evanlucas Have you changed the SVG file as well? If so, please add the file to the PR as well (put it in /static/images) and use svgo to optimize it before including it as base64. Thanks! |
evanlucas
commented
Aug 30, 2015
ContributorAuthor
I did not change it at all. It is the exact same as the non-mobile one |
fhemberger
commented
Aug 30, 2015
Contributor
Okay, then there's no need to include the file again, please just change the background-position in the media-query. |
evanlucas
commented
Aug 30, 2015
ContributorAuthor
ah ok |
evanlucas
commented
Aug 30, 2015
ContributorAuthor
Done |
fhemberger added a commit
that referenced
this pull request
Aug 30, 2015
Make footer look better on mobile
fhemberger
commented
Aug 30, 2015
Contributor
Cool, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: