Skip to content

fix: properly tag maintenance and flag versions correctly - #6586

Merged
ovflowd merged 1 commit into
mainfrom
fix/properly-identify-maintenance
Apr 1, 2024
Merged

fix: properly tag maintenance and flag versions correctly#6586
ovflowd merged 1 commit into
mainfrom
fix/properly-identify-maintenance

Conversation

@ovflowd

Copy link
Copy Markdown
Member

Description

This PR fixes an issue of a maintenance version being flagged as "Maintenance LTS" and we not rendering correctly maintenance versions.

Validation

On the preview branch, LTS version should again be marked as v20

Related Issues

Closes#6584

@ovflowd
ovflowd requested a review from a team as a code ownerApril 1, 2024 10:31
@vercel

vercelBot commented Apr 1, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewApr 1, 2024 10:32am

@github-actions

github-actionsBot commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟢 97🟢 96🟢 100🟢 91🔗
/en/about🟢 99🟢 96🟢 100🟢 91🔗
/en/about/previous-releases🟢 98🟢 95🟢 100🟢 92🔗
/en/download🟢 100🟢 95🟢 100🟢 91🔗
/en/blog🟢 98🟢 96🟢 100🟢 92🔗

@ovflowd

ovflowd commented Apr 1, 2024

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/nodejs-website @nodejs/web-infra as this solves a (imo) a critical bug as we're misleading at the moment people to non-LTS versions as "LTS"

Requesting Fast-Track

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 83%
79.33% (453/571)76.06% (143/188)69.91% (79/113)

Unit Test Report

TestsSkippedFailuresErrorsTime
900 💤0 ❌0 🔥4.465s ⏱️

@AugustinMauroyAugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!

@ovflowd
ovflowd added this pull request to the merge queueApr 1, 2024
Merged via the queue into main with commit cf31dafApr 1, 2024
@ovflowd
ovflowd deleted the fix/properly-identify-maintenance branch April 1, 2024 11:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackFast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homepage LTS link downloads non LTS version

2 participants

@ovflowd@AugustinMauroy