Skip to content

fix: proper release status - #6603

Merged
ovflowd merged 1 commit into
mainfrom
fix/proper-release-status
Apr 3, 2024
Merged

fix: proper release status#6603
ovflowd merged 1 commit into
mainfrom
fix/proper-release-status

Conversation

@ovflowd

@ovflowdovflowd commented Apr 2, 2024

Copy link
Copy Markdown
Member

Description

As per recommendation of the Node.js releasers, we should simplify our status stamping and ignore "Maintenance" statuses and only consider EOL statuses.

Validation

LTS and Current versions should still render properly and all the logic should be working as expected

Related Issues

Fixes#6584

@ovflowd
ovflowd requested a review from a team as a code ownerApril 2, 2024 10:28
@ovflowdovflowd added the github_actions:pull-request Trigger Pull Request Checks label Apr 2, 2024
@vercel

vercelBot commented Apr 2, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewApr 2, 2024 10:29am

@ovflowd

ovflowd commented Apr 2, 2024

Copy link
Copy Markdown
MemberAuthor

cc @targos

@github-actionsgithub-actionsBot removed the github_actions:pull-request Trigger Pull Request Checks label Apr 2, 2024
@github-actions

github-actionsBot commented Apr 2, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟢 96🟢 96🟢 100🟢 91🔗
/en/about🟢 100🟢 96🟢 100🟢 91🔗
/en/about/previous-releases🟢 96🟢 95🟢 100🟢 92🔗
/en/download🟢 99🟢 95🟢 100🟢 91🔗
/en/blog🟢 99🟢 96🟢 96🟢 92🔗

@github-actions

github-actionsBot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 91%
89.96% (574/638)76.1% (172/226)91.4% (117/128)

Unit Test Report

TestsSkippedFailuresErrorsTime
1200 💤0 ❌0 🔥5.368s ⏱️

AugustinMauroy
AugustinMauroy approved these changes Apr 2, 2024
View reviewed changes

@AugustinMauroyAugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@ovflowd
ovflowd added this pull request to the merge queueApr 3, 2024
Merged via the queue into main with commit 2d1b54aApr 3, 2024
@ovflowd
ovflowd deleted the fix/proper-release-status branch April 3, 2024 14:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmuenzenmeyerbmuenzenmeyerbmuenzenmeyer approved these changes
@aymen94aymen94aymen94 approved these changes
@canerakdascanerakdascanerakdas approved these changes
@araujoguiaraujoguiaraujogui approved these changes
@AugustinMauroyAugustinMauroyAugustinMauroy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Homepage LTS link downloads non LTS version

6 participants

@ovflowd@bmuenzenmeyer@aymen94@canerakdas@araujogui@AugustinMauroy