Skip to content

fix: fix example code - #6606

Closed
ExIxIxS wants to merge 1 commit into
nodejs:mainfrom
ExIxIxS:patch-1
Closed

fix: fix example code#6606
ExIxIxS wants to merge 1 commit into
nodejs:mainfrom
ExIxIxS:patch-1

Conversation

@ExIxIxS

@ExIxIxSExIxIxS commented Apr 3, 2024

Copy link
Copy Markdown

Description

Fixed a mistake in code example on the page

Validation

image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Denis Bondarenko <106703414+ExIxIxS@users.noreply.github.com>
@ExIxIxS
ExIxIxS requested a review from a team as a code ownerApril 3, 2024 10:25
@vercel

vercelBot commented Apr 3, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewApr 3, 2024 10:28am

@araujoguiaraujogui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟢 98🟢 96🟢 100🟢 91🔗
/en/about🟢 99🟢 96🟢 100🟢 91🔗
/en/about/previous-releases🟢 100🟢 95🟢 100🟢 92🔗
/en/download🟢 100🟢 95🟢 100🟢 91🔗
/en/blog🟢 97🟢 96🟢 100🟢 92🔗

@ovflowd

Copy link
Copy Markdown
Member

People keep making PRs to this specific example, because the output result at times will be different. This is probably the 5th time this example is updated having the output 4 and 3 swapped.

@ovflowdovflowd closed this Apr 3, 2024
@ovflowd

Copy link
Copy Markdown
Member

Closing this, as to be honest, the discrepancy is expected at times. cc @nodejs/collaborators as I'd really like to know the origin of why this happens.

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 91%
89.68% (574/640)75.1% (175/233)91.4% (117/128)

Unit Test Report

TestsSkippedFailuresErrorsTime
1200 💤0 ❌0 🔥5.319s ⏱️

@lemire

Copy link
Copy Markdown
Member

@ovflowd The output varies from run to run. You can just add it as a remark (The exact output may differ.)

Screenshot 2024-04-03 at 2 00 09 PM

@ovflowd

Copy link
Copy Markdown
Member

@ovflowd The output varies from run to run. You can just add it as a remark (The exact output may differ.)

Screenshot 2024-04-03 at 2 00 09 PM

Mind making a tiny PR? 🙃

@lemire

Copy link
Copy Markdown
Member

Sure. I will.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ExIxIxS@ovflowd@lemire@araujogui