Skip to content

content(learn cli): make up to date - #7307

Merged
AugustinMauroy merged 10 commits into
mainfrom
updat(learn)-cli
Dec 23, 2024
Merged

content(learn cli): make up to date#7307
AugustinMauroy merged 10 commits into
mainfrom
updat(learn)-cli

Conversation

@AugustinMauroy

@AugustinMauroyAugustinMauroy commented Dec 2, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Remove external package examples
  • Mention styleText API
  • Using links in latest-v22.x everywhere
  • Add mention of --run
  • Update .env explaining

Validation

  • All provided examples should work fine on v22
  • No typo 😄

Related Issues

No related issues.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@vercel

vercelBot commented Dec 2, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewDec 16, 2024 4:47pm

@AugustinMauroy

This comment was marked as outdated.

Sign in to view
@AugustinMauroy
AugustinMauroy marked this pull request as ready for review December 2, 2024 10:17
@AugustinMauroy
AugustinMauroy requested a review from a team as a code ownerDecember 2, 2024 10:17
CopilotAI reviewed Dec 2, 2024
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (1)

apps/site/pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md:17

  • The angle brackets around the URL are unnecessary. It should be: "shebang".
You can also embed this information into your JavaScript file with a ["shebang"](<https://en.wikipedia.org/wiki/Shebang_(Unix)>) line.

Comment threadapps/site/pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md Outdated
@AugustinMauroy
fix typo
37699f6
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
ovflowd
ovflowd approved these changes Dec 13, 2024
View reviewed changes

@ovflowdovflowd left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nodejs/tsc for review, but I gave a light pass and 👍

ruyadorno
ruyadorno reviewed Dec 16, 2024
View reviewed changes
Comment threadapps/site/pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md Outdated
@AugustinMauroy@ruyadorno
rephrase sentences
60239c4
Co-authored-by: Ruy Adorno <ruyadorno@google.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@AugustinMauroy

AugustinMauroy commented Dec 21, 2024

Copy link
Copy Markdown
MemberAuthor

Let's merge this ?

@AugustinMauroyAugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Dec 22, 2024
@github-actionsgithub-actionsBot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 22, 2024
@github-actions

github-actionsBot commented Dec 22, 2024

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 92%
90.79% (631/695)72.44% (184/254)94.53% (121/128)

Unit Test Report

TestsSkippedFailuresErrorsTime
1430 💤0 ❌0 🔥4.943s ⏱️

@AugustinMauroy
AugustinMauroy added this pull request to the merge queueDec 23, 2024
Merged via the queue into main with commit 56cdefbDec 23, 2024
@AugustinMauroy
AugustinMauroy deleted the updat(learn)-cli branch December 23, 2024 11:40
This was referenced Jul 19, 2025
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadornoruyadornoruyadorno left review comments
@ovflowdovflowdovflowd approved these changes
@mikeestomikeestomikeesto left review comments
Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AugustinMauroy@ruyadorno@ovflowd@mikeesto@marco-ippolito