Skip to content

fix: compatibility engine should run even on initial state - #7366

Merged
ovflowd merged 6 commits into
mainfrom
hotfix/disabled-items-during-loading-state
Dec 28, 2024
Merged

fix: compatibility engine should run even on initial state#7366
ovflowd merged 6 commits into
mainfrom
hotfix/disabled-items-during-loading-state

Conversation

@ovflowd

@ovflowdovflowd commented Dec 28, 2024

Copy link
Copy Markdown
Member

This PR prevents the compatibility engine to simply say it is compatible when on a loading state.

@ovflowd
ovflowd requested a review from a team as a code ownerDecember 28, 2024 17:48
@vercel

vercelBot commented Dec 28, 2024•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewDec 28, 2024 6:07pm

@ovflowdovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actionsgithub-actionsBot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions

github-actionsBot commented Dec 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟠 75🟢 100🟢 100🟢 91🔗
/en/about🟢 100🟢 100🟢 100🟢 91🔗
/en/about/previous-releases🟢 99🟢 100🟢 100🟢 92🔗
/en/download🟠 82🟢 100🟢 100🟢 91🔗
/en/blog🟢 100🟢 100🟢 96🟢 92🔗

@github-actions

github-actionsBot commented Dec 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 85%
84.08% (597/710)65.12% (183/281)82.7% (110/133)

Unit Test Report

TestsSkippedFailuresErrorsTime
1240 💤0 ❌0 🔥4.881s ⏱️

@ovflowdovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actionsgithub-actionsBot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
ljharb
ljharb approved these changes Dec 28, 2024
View reviewed changes

@ljharbljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the issue with AIX being available on initial load, but it'd be good to have tests :-) (here or in a followup)

@ovflowdovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Dec 28, 2024
@github-actionsgithub-actionsBot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@ovflowd

ovflowd commented Dec 28, 2024

Copy link
Copy Markdown
MemberAuthor

This addresses the issue with AIX being available on initial load, but it'd be good to have tests :-) (here or in a followup)

Indeed. I'm unfortunately out of bandwidth right now for tests (which could have captured this) -- maybe our test guru @AugustinMauroy can help us here 🙏

@ovflowd

ovflowd commented Dec 28, 2024

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/nodejs-website fast-tracking as a hot fix 🙏

@ovflowd
ovflowd merged commit c8e604f into mainDec 28, 2024
@ovflowd
ovflowd deleted the hotfix/disabled-items-during-loading-state branch December 28, 2024 18:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharbljharbljharb approved these changes

Assignees

No one assigned

Labels

fast-trackFast Tracking PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd@ljharb