Skip to content

fix: ensure code elements within links display correct link styling (#7339) - #7386

Merged
bmuenzenmeyer merged 1 commit into
nodejs:mainfrom
mpruser:main
Jan 6, 2025
Merged

fix: ensure code elements within links display correct link styling (#7339)#7386
bmuenzenmeyer merged 1 commit into
nodejs:mainfrom
mpruser:main

Conversation

@mpruser

Copy link
Copy Markdown
Contributor

Description

ensure code elements within links display correct link styling

  • Adjusted CSS specificity to ensure code elements within links inherit link styling.
  • This change addresses the issue where code elements inside links did not appear as links, improving visual consistency and accessibility.

Validation

BeforeAfter
스크린샷 2025-01-04 오후 3 07 52스크린샷 2025-01-04 오후 3 07 43

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@mpruser
mpruser requested a review from a team as a code ownerJanuary 4, 2025 06:30
@vercel

vercelBot commented Jan 4, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewJan 4, 2025 6:31am

@github-actions

github-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟢 100🟢 100🟢 100🟢 91🔗
/en/about🟢 100🟢 100🟢 100🟢 91🔗
/en/about/previous-releases🟢 99🟢 100🟢 100🟢 92🔗
/en/download🟢 94🟢 100🟢 100🟢 91🔗
/en/blog🟢 100🟢 100🟢 96🟢 92🔗

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 88%
87.1% (736/845)72.13% (233/323)86.33% (139/161)

Unit Test Report

TestsSkippedFailuresErrorsTime
1850 💤0 ❌0 🔥5.447s ⏱️

@bmuenzenmeyer
bmuenzenmeyer added this pull request to the merge queueJan 6, 2025
Merged via the queue into nodejs:main with commit 4b710a9Jan 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mpruser@bmuenzenmeyer