Skip to content

hot fix: fixed i18n and i18n types - #7394

Merged
ovflowd merged 1 commit into
mainfrom
fix/fixed-locale-import
Jan 8, 2025
Merged

hot fix: fixed i18n and i18n types#7394
ovflowd merged 1 commit into
mainfrom
fix/fixed-locale-import

Conversation

@ovflowd

Copy link
Copy Markdown
Member

This PR fixes a bug introduced on a sibling PR (by me), due to types within a parent package been incorrectly typed.

Fixes#7391

@ovflowd
ovflowd requested a review from a team as a code ownerJanuary 8, 2025 02:33
@vercel

vercelBot commented Jan 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewJan 8, 2025 2:33am

@ovflowd

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/nodejs-website I'm going to fast-track this as an Administrator as a hot-fix to fix i18n on the website.

@ovflowdovflowd changed the title fix: fixed i18n and i18n typeshot fix: fixed i18n and i18n typesJan 8, 2025
@github-actions

github-actionsBot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟢 99🟢 100🟢 100🟢 91🔗
/en/about🟢 100🟢 100🟢 100🟢 91🔗
/en/about/previous-releases🟢 100🟢 100🟢 100🟢 92🔗
/en/download🟢 99🟢 100🟢 100🟢 91🔗
/en/blog🟢 100🟢 100🟢 96🟢 92🔗

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 88%
87.6% (735/839)74.14% (238/321)86.58% (142/164)

Unit Test Report

TestsSkippedFailuresErrorsTime
1820 💤0 ❌0 🔥5.377s ⏱️

@ovflowd
ovflowd merged commit 8fc5765 into mainJan 8, 2025
@ovflowd
ovflowd deleted the fix/fixed-locale-import branch January 8, 2025 02:42
@bjohansebasbjohansebas mentioned this pull request May 16, 2025
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackFast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The translation is broken

1 participant

@ovflowd