Skip to content

Use console.error() for errors consistently - #7411

Merged
AugustinMauroy merged 1 commit into
nodejs:mainfrom
dragunovartem99:patch-1
Jan 20, 2025
Merged

Use console.error() for errors consistently#7411
AugustinMauroy merged 1 commit into
nodejs:mainfrom
dragunovartem99:patch-1

Conversation

@dragunovartem99

@dragunovartem99dragunovartem99 commented Jan 18, 2025

Copy link
Copy Markdown
Contributor

In all examples in this document errors are logged by using console.error() method

And it's unclear why in promise-based part we have different strategy

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

In all examples in this document errors are logged by using `console.error()` method
And it's unclear why in promise-based part we have different strategy
Signed-off-by: Artem Dragunov <dragunovartem99@gmail.com>
@dragunovartem99
dragunovartem99 requested a review from a team as a code ownerJanuary 18, 2025 09:05
@vercel

vercelBot commented Jan 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewJan 18, 2025 9:06am

@github-actions

github-actionsBot commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟢 100🟢 100🟢 100🟢 91🔗
/en/about🟢 100🟢 100🟢 100🟢 91🔗
/en/about/previous-releases🟢 100🟢 100🟢 100🟢 92🔗
/en/download🟢 97🟢 100🟢 100🟢 91🔗
/en/blog🟢 100🟢 100🟢 96🟢 92🔗

@github-actions

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

LinesStatementsBranchesFunctions
Coverage: 88%
87.55% (739/844)74.14% (238/321)86.58% (142/164)

Unit Test Report

TestsSkippedFailuresErrorsTime
1820 💤0 ❌0 🔥5.491s ⏱️

@AugustinMauroy
AugustinMauroy added this pull request to the merge queueJan 20, 2025
Merged via the queue into nodejs:main with commit c6df7d2Jan 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@dragunovartem99@bmuenzenmeyer@ovflowd@aymen94@mikeesto@AugustinMauroy