Skip to content

feat(test): replace cloudflare open-next build test with playwright tests - #7782

Merged
ovflowd merged 8 commits into
nodejs:mainfrom
dario-piotrowicz:main
Jun 1, 2025
Merged

feat(test): replace cloudflare open-next build test with playwright tests#7782
ovflowd merged 8 commits into
nodejs:mainfrom
dario-piotrowicz:main

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

Description

Replaces the github workflow checking that the Cloudflare open-next build process works on PRs and pushes to main with a workflow that runs and checks the open-next build using playwright (built on top of the changes introduced in #7749)

Validation

I've validated this change by pushing this onto my fork's main branch and you can see the workflow working as expected there by checking the action runs (example)

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

CopilotAI review requested due to automatic review settings May 27, 2025 14:21
@dario-piotrowicz
dario-piotrowicz requested review from a team as code ownersMay 27, 2025 14:21
@vercel

vercelBot commented May 27, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit PreviewMay 30, 2025 8:50pm

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the GitHub workflow that verifies the Cloudflare open-next build with a new workflow that runs Playwright tests to validate the build.

  • Updated Playwright configuration to support dynamic web server setup via environment variables.
  • Replaced the Cloudflare worker build test with a Playwright test workflow that includes caching, browser installation, and report upload.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
apps/site/playwright.config.tsUpdated Playwright configuration including conditional web server launch and dynamic baseURL setup.
.github/workflows/playwright-cloudflare-open-next.ymlReplaced the Cloudflare build job with a Playwright testing job along with concurrency and caching improvements.

Comment threadapps/site/playwright.config.ts
Comment thread.github/workflows/playwright-cloudflare-open-next.yml
@codecov-commenter

codecov-commenter commented May 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (d122e58) to head (daeddef).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #7782 +/- ##
=======================================
Coverage 75.35% 75.36% =======================================
Files 96 96 Lines 7861 7862 +1 Branches 192 192 =======================================
+ Hits 5924 5925 +1 
Misses 1936 1936 Partials 1 1 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment threadapps/site/playwright.config.ts
Comment threadapps/site/playwright.config.ts Outdated
Comment thread.github/workflows/playwright-cloudflare-open-next.yml
Comment threadapps/site/playwright.config.ts Outdated
…right tests
update forgotten env variable name in playwright.yml
…right tests
still accept VERCEL_PREVIEW_URL to make PR go green
Comment threadapps/site/playwright.config.ts Outdated

@AugustinMauroyAugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

Comment threadapps/site/playwright.config.ts Outdated
…right tests
avoid running a script taken from process.env
…right tests
add new getWebServerConfig function instead of using a ternary
Comment threadapps/site/playwright.config.ts
@ovflowdovflowd added the github_actions:pull-request Trigger Pull Request Checks label Jun 1, 2025
@ovflowd
ovflowd enabled auto-merge June 1, 2025 01:32
@github-actionsgithub-actionsBot removed the github_actions:pull-request Trigger Pull Request Checks label Jun 1, 2025
@github-actions

github-actionsBot commented Jun 1, 2025

Copy link
Copy Markdown
Contributor

Lighthouse Results

URLPerformanceAccessibilityBest PracticesSEOReport
/en🟠 77🟢 100🟢 100🟢 91🔗
/en/about🟢 100🟢 100🟢 100🟠 82🔗
/en/about/previous-releases🟢 100🟢 100🟢 100🟠 83🔗
/en/download🟢 98🟢 100🟢 100🟢 91🔗
/en/blog🟢 100🟢 100🟢 96🟢 92🔗

@ovflowd
ovflowd added this pull request to the merge queueJun 1, 2025
Merged via the queue into nodejs:main with commit 5b2c9fbJun 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@dario-piotrowicz@codecov-commenter@ovflowd@avivkeller@flakey5@AugustinMauroy