Skip to content

fix(ci): disable all locale export - #8440

Merged
MattIPv4 merged 2 commits into
mainfrom
fixup
Dec 22, 2025
Merged

fix(ci): disable all locale export#8440
MattIPv4 merged 2 commits into
mainfrom
fixup

Conversation

@avivkeller

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Aviv Keller <me@aviv.sh>
CopilotAI review requested due to automatic review settings December 22, 2025 21:08
@avivkeller
avivkeller requested a review from a team as a code ownerDecember 22, 2025 21:08
@vercel

vercelBot commented Dec 22, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
nodejs-orgReadyReadyPreviewDec 22, 2025 9:12pm

@github-actions

Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the export of all locales in the CI build process due to space constraints. The change removes the conditional logic that previously exported all locales only on push events while restricting pull_request events to the default locale only.

Key Changes:

  • Removed the NEXT_PUBLIC_STATIC_EXPORT_LOCALE environment variable that conditionally enabled all-locale exports
  • Added a TODO comment noting that exporting all locales consumes too much space

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread.github/workflows/build.yml Outdated
@codecov

codecovBot commented Dec 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (6de27a1) to head (0ee76b8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #8440 +/- ##
==========================================
- Coverage 73.65% 73.64% -0.02% 
==========================================
Files 108 108 Lines 9193 9193 Branches 312 312 ==========================================
- Hits 6771 6770 -1 - Misses 2420 2421 +1 
Partials 2 2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aviv Keller <me@aviv.sh>

@MattIPv4MattIPv4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure to file a follow-up issue to discuss getting a larger runner for this

@MattIPv4

Copy link
Copy Markdown
Member

This should be fast-trackable as a small fix :)

@github-actions

github-actionsBot commented Dec 22, 2025

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

MetricValue
Old Total Size4.41 MB
New Total Size4.41 MB
Delta0 B (0.00%)

Changes

➕ Added Assets (1)
NameSize
.next/static/chunks/948dbad21b6ae055.js204.26 KB
➖ Removed Assets (1)
NameSize
.next/static/chunks/c61b8ca0e028e1d7.js204.26 KB

@MattIPv4
MattIPv4 added this pull request to the merge queueDec 22, 2025
Merged via the queue into main with commit 1a7effbDec 22, 2025
12 checks passed
@MattIPv4
MattIPv4 deleted the fixup branch December 22, 2025 22:40
@avivkelleravivkeller mentioned this pull request Dec 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@avivkeller@MattIPv4@canerakdas