Skip to content

hotfix: this pr hotfixes a few styles - #8608

Merged
bmuenzenmeyer merged 1 commit into
mainfrom
hotfix/ui-components-styles
Feb 5, 2026
Merged

hotfix: this pr hotfixes a few styles#8608
bmuenzenmeyer merged 1 commit into
mainfrom
hotfix/ui-components-styles

Conversation

@ovflowd

Copy link
Copy Markdown
Member

This PR is a hot-fix for certain styles/breakpoints, including the overflow caused due to z-index on Sidebar as shown below (happens only on certain breakpoints)

image

CopilotAI review requested due to automatic review settings February 5, 2026 11:23
@ovflowd
ovflowd requested a review from a team as a code ownerFebruary 5, 2026 11:23
@vercel

vercelBot commented Feb 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
nodejs-orgReadyReadyPreviewFeb 5, 2026 11:23am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov

codecovBot commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.02%. Comparing base (45d2316) to head (3737458).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #8608 +/- ##
==========================================
- Coverage 75.03% 75.02% -0.02% 
==========================================
Files 103 103 Lines 9062 9062 Branches 312 312 ==========================================
- Hits 6800 6799 -1 - Misses 2260 2261 +1 
Partials 2 2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a hotfix that addresses style and layout issues at certain breakpoints, particularly fixing an overflow problem caused by z-index conflicts with the Sidebar component. It also updates the codebase to use Tailwind CSS v4's new data attribute syntax.

Changes:

  • Updated data attribute syntax from Tailwind v3 format (data-[attribute]) to v4 format (data-attribute)
  • Fixed sidebar overflow issue by adding z-0 to explicitly set its stacking context
  • Adjusted breakpoints from 670px to 890px for better responsive behavior
  • Bumped package version to 1.5.10

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

FileDescription
packages/ui-components/src/Containers/Sidebar/index.module.cssAdded z-0 to sidebar wrapper to fix overflow issues
packages/ui-components/src/Common/Select/index.module.cssUpdated data attribute syntax to Tailwind v4 format and increased dropdown z-index from z-99 to z-999
packages/ui-components/package.jsonBumped version from 1.5.9 to 1.5.10
apps/site/components/withMetaBar.tsxAdjusted responsive breakpoints from 670px to 890px for mobile and tablet resolutions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/ui-components/src/Common/Select/index.module.css
@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

MetricValue
Old Total Size3.75 MB
New Total Size3.75 MB
Delta0 B (0.00%)

Changes

➕ Added Assets (2)
NameSize
.next/static/chunks/a2c168506720f193.js207.00 KB
.next/static/chunks/0c41dccdba90e18c.js28.81 KB
➖ Removed Assets (2)
NameSize
.next/static/chunks/dde9d6d0d8c035cb.js207.00 KB
.next/static/chunks/669065f97384d5cd.js28.81 KB

@bmuenzenmeyer

Copy link
Copy Markdown
Contributor

agree broken, not waiting the 2 day here

@bmuenzenmeyer
bmuenzenmeyer added this pull request to the merge queueFeb 5, 2026
Merged via the queue into main with commit 097cac6Feb 5, 2026
20 checks passed
@bmuenzenmeyer
bmuenzenmeyer deleted the hotfix/ui-components-styles branch February 5, 2026 17:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ovflowd@bmuenzenmeyer