Skip to content

fix(doc-kit): 'property' to the code like array - #8705

Merged
avivkeller merged 1 commit into
mainfrom
property
Mar 8, 2026
Merged

fix(doc-kit): 'property' to the code like array#8705
avivkeller merged 1 commit into
mainfrom
property

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Fixes partially code-like text, i.e.:
image

Signed-off-by: Aviv Keller <me@aviv.sh>
CopilotAI review requested due to automatic review settings March 7, 2026 20:50
@avivkeller
avivkeller requested a review from a team as a code ownerMarch 7, 2026 20:50
@vercel

vercelBot commented Mar 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
nodejs-orgReadyReadyPreviewMar 7, 2026 8:50pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the UI components’ “code-like heading” detection so doc-kit headings tagged as property are styled consistently as code-like (e.g., in TOC / meta navigation).

Changes:

  • Add 'property' to the CODE_LIKE_TYPES set used to apply code-like link styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecovBot commented Mar 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (82684bc) to head (a642089).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #8705 +/- ##
==========================================
- Coverage 75.10% 75.09% -0.01% 
==========================================
Files 104 104 Lines 9161 9162 +1 Branches 315 315 ==========================================
Hits 6880 6880 - Misses 2279 2280 +1 
Partials 2 2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

MetricValue
Old Total Size3.51 MB
New Total Size3.51 MB
Delta11.00 B (0.00%)

Changes

➕ Added Assets (2)
NameSize
.next/static/chunks/f62865bdfb05e0e1.js208.15 KB
.next/static/chunks/afc03cd6290b8b45.js36.52 KB
➖ Removed Assets (2)
NameSize
.next/static/chunks/3d46284d5f545833.js208.15 KB
.next/static/chunks/810340e79c93109b.js36.51 KB

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, happy to fast-track too!

@avivkeller
avivkeller added this pull request to the merge queueMar 8, 2026
Merged via the queue into main with commit abe2187Mar 8, 2026
17 checks passed
@avivkeller
avivkeller deleted the property branch March 8, 2026 21:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@avivkeller@ovflowd@mikeesto@AugustinMauroy