Uh oh!
There was an error while loading. Please reload this page.
Update to Node v10.17.0 - #420
Conversation
Uh oh!
There was an error while loading. Please reload this page.
mcollina
commented
Oct 24, 2019
@vweevers have you got an idea on why the browser tests are not running at all? |
vweevers
commented
Oct 24, 2019
Maybe because it's running on node 13? I haven't tested |
vweevers
commented
Oct 25, 2019
Looks like the same thing is happening on node 12. @mcollina Does |
mcollina
commented
Oct 25, 2019
@vweevers turns out the problem was in the code. They are passing locally now. |
mcollina
commented
Oct 25, 2019
@vweevers there seems to be an issue with IE11. The new I see a some options:
I do not see many other options, but maybe there are. I would really like to ship this update because it will remove the warning for async iteration. It’s about time. |
vweevers
commented
Oct 26, 2019
+1. For what it's worth, feross's
-1. Modularity is good, but in this case it's too surprising for users, because
If you mean disabling it (until the next major) then +1.
-1. Although regenerator is small, it does add up if multiple modules include it, so I think polyfilling like this should be an application concern. |
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
mcollina
commented
Jan 16, 2020
Updated to Node 10.18.1, let's see how it goes. |
mcollina
commented
Jan 17, 2020
🎉 CI is passing. @vweevers@mafintosh would you like to take a final look? |
vweevers
commented
Jan 17, 2020
Approved it seconds before your comment :) I suggest updating the PR title for the record. |
* Update to Node v10.17.0 * Browsers might not have Symbol, from edition * Use Node 12 for airtap * test passing on browser * Update to Node 10.18.1 * fixed file patterns for build * possibly browser fix * test passing down to Node 6
This is important because it adds:
Readable.from()