Uh oh!
There was an error while loading. Please reload this page.
Remove Circular dep that was not needed - #441
Conversation
| function Duplex(options) { | ||
| if (!(this instanceof Duplex)) return new Duplex(options); | ||
| this.isDuplex = true |
There was a problem hiding this comment.
I don't think we can just add public properties like that... would at least need to be behind a symbol
There was a problem hiding this comment.
Can you explain any reason for that? I do not see a case where i can not simply place that i will refactor that but i do not see why we should not be able to place it after we made sure we are called with new we are sure that this is a instance and i am 100% sure that no novice developer will mess with that propertie
and if he does it is up to him it still has no down side for this
If you want this fixed I think you would first need to open a PR against the node core repo, https://github.com/nodejs/node. Please the discussion in #348. |
vweevers
commented
Sep 19, 2020
Closing in favor of upstream PR: nodejs/node#35239. Follow #348 for further progress. Thanks for contributing! |
Closes: #348
Makes this package able remove circular dep