Uh oh!
There was an error while loading. Please reload this page.
Conversation
Uh oh!
There was an error while loading. Please reload this page.
aduh95
marked this pull request as draft
June 27, 2025 15:56
aduh95
marked this pull request as ready for review
June 28, 2025 23:38
aduh95force-pushed
the
add-ci
branch
2 times, most recently
from
June 30, 2025 19:55
750ab59 to
8d492e7CompareUh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Jul 8, 2025
ContributorAuthor
@nodejs/releasers can I get some reviews please? |
aduh95 added a commit
that referenced
this pull request
Jul 9, 2025
Uh oh!
There was an error while loading. Please reload this page.
aduh95 added a commit
that referenced
this pull request
Jul 11, 2025
aduh95 added a commit
that referenced
this pull request
Jul 15, 2025
aduh95 added a commit
that referenced
this pull request
Jul 15, 2025
richardlau
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-gpg-dir.shscript – mostly useful for CIWhat's missing:
addmoving this to feat: addgpg-only-active-keysfolder, for folks who only want to check "future" releases rather than past ones.gpg-only-active-keys/keyring #38a check to ensure README is in sync with nodejs/node READMEchore(ci): validate README lists of keys #39a check to ensure latest versions of all non-EOL release lines can be verified with the "only-active-keys" keyringchore(ci): validate non-EOL releases are signed with an "active" key #43