Uh oh!
There was an error while loading. Please reload this page.
Updated to Node 8.1.2 - #3
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
calvinmetcalf
commented
Jun 27, 2017
Contributor
it's actually the current one too that fails in node 8 |
mcollina
commented
Jun 27, 2017
MemberAuthor
the current one fails on node >= 8, while this one fails on Node < 8 |
calvinmetcalf
commented
Jun 27, 2017
Contributor
ah, confusing breaking change of some sort |
mcollina
commented
Jun 27, 2017
MemberAuthor
So, I think it might be related to something low level, and we need to abstract the test. |
mcollina
commented
Jun 27, 2017
MemberAuthor
I think this the source of the problem: nodejs/node@24ef1e6 I think we should just conditionally pick the right test depending on the version of V8 we running against. |
mcollina
commented
Jun 27, 2017
MemberAuthor
I have disabled the V8-dependant checks. |
4 tasks
mcollina
commented
Feb 28, 2018
MemberAuthor
Closed in favor of #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@addaleax Can you have a look while this fails in Node < 8?
cc @calvinmetcalf