Uh oh!
There was an error while loading. Please reload this page.
Check in resources/scripts for coverage generation - #38
Conversation
Add patch files that enable coverage generation for Node core as well as a simple script for rendering a table of nightly coverage results. Ref: nodejs#36
mhdawson
commented
Oct 13, 2016
LGTM |
mhdawson
commented
Oct 13, 2016
I'm not actually a member of the testing team so not sure if I should/can land. @nodejs/testing for more review/comments. |
Trott
commented
Oct 13, 2016
Is this the right repo for these files? This repo generally doesn't have any code, just documentation and guides and whatnot. Fine with it if it's the best place. But just curious if the actual coverage code is living somewhere else and it should go there? |
addaleax
commented
Oct 13, 2016
I think it’s going to end up in the Jenkins config in some way, if I’ve understood @mhdawson correctly? |
Trott
commented
Oct 13, 2016
Would https://github.com/nodejs/build be the right place for it then? /cc @mhdawson@jbergstroem |
mhdawson
commented
Oct 20, 2016
These files will be used by the job in jenkins. I was thinking they'd go in the testing repo as something associated/owned by the testing group. It is also the same approach we took for the files supporting the nightly benchmarking jobs. Having said that if others think it should be in the build repo instead I'm fine with that as well. @jbergstroem what's your take ? |
mhdawson
commented
Oct 24, 2016
I talked with @jbergstroem through IRC and he seemed ok with them going here. Unless I hear additional objections I'll go ahead and land in the next day or so. |
mhdawson
commented
Nov 1, 2016
landed as d41c55d |
Add patch files that enable coverage generation for Node core
as well as a simple script for rendering a table of nightly
coverage results.
Ref: #36
The files are taken as they are in https://github.com/addaleax/node-core-coverage
/cc @mhdawson